Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete topical event about pages frontend parts #2467

Merged
merged 2 commits into from Feb 15, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 11, 2016

Should not be merged until topical event about pages have been migrated and are being served by government frontend.

  • Delete template, styles, controller and tests
  • Update feature to test for presence of link but not to follow it, it won’t render any more (use less generic read more link text)
  • Delete govspeak_header_contents.html.erb partial

https://trello.com/c/H8mRXMTV/268-3-topical-event-about-page-migration-final-tasks-for-each-format-deploy-2-medium

fofr added 2 commits Feb 11, 2016
* Delete template, styles, controller and tests
* Update feature to test for presence of link but not to follow it, it
won’t render any more (use less generic read more link text)
Partial was being used by about pages and corporate info pages. As it’s
sole use is now corp info pages, the “shared” partial can be deleted
and the markup moved to the specific view.
@benlovell
Copy link
Contributor

@benlovell benlovell commented Feb 12, 2016

🚢 when ready.

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Feb 12, 2016

This is now ready to be merged 👍

@benlovell benlovell changed the title [DO NOT MERGE] Delete topical event about pages frontend parts Delete topical event about pages frontend parts Feb 12, 2016
fofr added a commit that referenced this pull request Feb 15, 2016
Delete topical event about pages frontend parts
@fofr fofr merged commit 4392720 into master Feb 15, 2016
1 check passed
1 check passed
default Build #7486 succeeded on Jenkins
Details
@fofr fofr deleted the delete-topical-event-about-pages branch Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.