Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix "View on website" link for non-editioned topical events and get involved content #2469
When clicking “View on website” for classifications it shows the whitehall admin rendered version of it.
Viewing a topical event page from
It's a similar story for get involved/take part pages.
Classification and get involved changes go live immediately. Instead send users to the public host with a cache bust query parameter.
This will continue to be a problem as we migrate more formats. A story to solve this more completely is being added to the Core backlog.
When clicking “View on website” for classifications it shows the whitehall admin rendered version of it. Viewing a topical event page from `whitehall-admin. …` means the relative link to its about page also points to `whitehall-admin`, however that is now served by government front-end and this route errors. Classification changes go live immediately. Instead send users to the public host with a cache bust query parameter. Create a separate `public_classification_url` helper so as not to interfere with: * atom feed generation * symmetry between existing helpers and topic_url/topical_event_url
To reduce the chance of users running into a page served by `whitehall-admin` that has subsequently been migrated to `government-frontend`, point classification and get involved “View website” links to the public host with a cache bust parameter.
…ls which are not inheriting from Edition. These links allow editors to see the page on the live site. These pages will not be rendered by Whitehall anymore, but from Government Frontend instead, so the simple path has been substituted by the full url path, as already done here: #2469. The first list of non-editioned formats has been grab from here: https://docs.google.com/spreadsheets/d/17jmUukUhb-bg3L-Kspvtogo-4eEek3IVk_qxRA1r3D0/edit#gid=0