Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spacing of stat headlines #2472

Merged
merged 1 commit into from Feb 19, 2016
Merged

Improve spacing of stat headlines #2472

merged 1 commit into from Feb 19, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 18, 2016

  • Reduce the bottom margin of stat headlines at smaller page widths to better match page flow (30px down to 15px)
  • Add a top margin to stat headlines when they are the very first piece of content. Match the margins used for h2s and h3s. Use > and first-child to be sure this only applies when shown first. (eg not
    first in a call to action)

Top of HTML publication

Before

screen shot 2016-02-18 at 20 41 58

## After

screen shot 2016-02-18 at 20 49 15

# Mobile spacing ## Before

screen shot 2016-02-18 at 20 51 31

## After

screen shot 2016-02-18 at 20 49 30

* Reduce the bottom margin of stat headlines at smaller page widths to
better match page flow (30px down to 15px)
* Add a top margin to stat headlines when they are the very first piece
of content. Match the margins used for h2s and h3s. Use `>` and
`first-child` to be sure this only applies when shown first. (eg not
first in a call to action)
@benlovell
Copy link
Contributor

@benlovell benlovell commented Feb 18, 2016

👍

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Feb 18, 2016

LGTM 👍

fofr added a commit that referenced this pull request Feb 19, 2016
Improve spacing of stat headlines
@fofr fofr merged commit 0e755fa into master Feb 19, 2016
1 check passed
1 check passed
default Build #7531 succeeded on Jenkins
Details
@fofr fofr deleted the stats-headline-spacing branch Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.