Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table alignment (take 2) #2584

Merged
merged 2 commits into from May 11, 2016
Merged

Add table alignment (take 2) #2584

merged 2 commits into from May 11, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 9, 2016

Second attempt after #2574.
Includes fixes from alphagov/govspeak#75

  • Should be deployed to staging to check for errors with traffic replay.

For columns containing numbers it’s easier to scan the list if they are right aligned (eg if every number is two decimal places).

https://trello.com/c/6ld11Eck/346-right-alignment-in-tables-in-govspeak-medium
https://govuk.zendesk.com/agent/tickets/1271189

(Copy has been ran past Liz L)

Guidance

screen shot 2016-05-03 at 14 29 30

Output

screen shot 2016-05-03 at 14 29 16

fofr added 2 commits May 3, 2016
For columns containing numbers it’s easier to scan the list if they are
right aligned (eg every number is two decimal places).
* Increase minimum Kramdown version to 1.10.0
* Include support for right aligned columns in table
* Includes fix for previously erroring IAL links:
alphagov/govspeak#75
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented May 9, 2016

👍 deploy branch to staging when ready

@fofr fofr changed the title [Do not merge] Add table alignment (take 2) Add table alignment (take 2) May 11, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented May 11, 2016

Branch now on staging, looking good.

@fofr fofr merged commit 692186f into master May 11, 2016
1 check passed
1 check passed
default Build #8282 succeeded on Jenkins
Details
@fofr fofr deleted the add-table-alignment branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.