Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external link styles #2839

Merged
merged 4 commits into from Nov 21, 2016
Merged

Remove external link styles #2839

merged 4 commits into from Nov 21, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 18, 2016

After static was updated to latest toolkit, the external link styles were removed but some extra styles still remained in Whitehall, breaking the display of external links.

  • Update toolkit to 5.0.0
  • Remove use of mixins no longer provided by toolkit
  • Remove white external link shim
  • Remove white external link images
  • Correct typo in accordion asset

Original PR and discussion:
alphagov/govuk_frontend_toolkit#293

cc @nickcolley

fofr added 3 commits Nov 18, 2016
After static was updated to latest toolkit, the external link image
disappeared, breaking the display of external links in apps.

* Remove use of mixins no longer provided by toolkit
* Remove white external link shim
* Remove white external link images

Original PR and discussion:
alphagov/govuk_frontend_toolkit#293
* Accordion not accordian.
* Keep Whitehall consistent with frontend toolkit.
@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Nov 21, 2016

Guess we want to get rid of

<p>The link will display with an external link symbol.</p>
as well?

@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Nov 21, 2016

Also this block might not be needed?

a[rel="external"]:after {

Apart from that it looks good.

The symbol no longer appears next to the link.
@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 21, 2016

@robinwhittleton Thanks for the review. I've removed the guidance about the icon. The second bit is part of the admin UI and is a different kind of icon/feature which can be left in.

@fofr fofr merged commit e75c554 into master Nov 21, 2016
1 check passed
1 check passed
default Build #9874 succeeded on Jenkins
Details
@fofr fofr deleted the remove-external-link-styles branch Nov 21, 2016
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Nov 21, 2016

Great work thanks @fofr 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.