Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply service priority styles to just featured links #3025

Merged
merged 1 commit into from Feb 8, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 8, 2017

  • The feature links styles for a service priority home page were
    leaking into the translation bar
  • Tighten up the selectors so they only apply to the list of links
  • Add a margin fix so that the translation bar lines up

Seen on HM Courts & Tribunals Service
https://govuk.zendesk.com/agent/tickets/1798173

Before

screen shot 2017-02-08 at 12 39 56

After

screen shot 2017-02-08 at 12 40 13

cc @boffbowsh

* The feature links styles for a service priority home page were
leaking into the translation bar
* Tighten up the selectors so they only apply to the list of links
* Add a margin fix so that the translation bar lines up

Seen on HM Courts & Tribunals Service
https://govuk.zendesk.com/agent/tickets/1798173
Copy link
Contributor

@boffbowsh boffbowsh left a comment

💥

@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 8, 2017

Test failures seem unrelated.

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Feb 8, 2017

Tests passing now @fofr

@fofr fofr merged commit 3fc8ff6 into master Feb 8, 2017
1 check passed
1 check passed
@govuk-ci
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the fix-translation-on-org-home branch Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants