Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set worldwide corporate information page rendering_app to Whitehall #3165

Merged
merged 1 commit into from Apr 11, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 11, 2017

Corporate information pages were migrated, but worldwide versions were not.

Without the rendering_app logic, the preview on website button links to draft origin rather than Whitehall frontend. This then 404s.

Fixes https://govuk.zendesk.com/agent/tickets/2063923, so far as it now points users at Whitehall rather than a 404.

However they still can't see the preview of their current draft because of the redirect in routes:
https://github.com/alphagov/whitehall/blob/allow-worldwide-corp-info-previews/config/routes.rb#L141

cc @andrewgarner @gpeng

Corporate information pages were migrated, but worldwide versions were
not. Without the rendering_app logic, the preview on website button
links to draft origin rather than Whitehall frontend.

Fixes https://govuk.zendesk.com/agent/tickets/2063923
@gpeng
gpeng approved these changes Apr 11, 2017
Copy link
Contributor

@gpeng gpeng left a comment

Not ideal but I appreciate this returns it to the arguably slightly less broken pre-migration behaviour.

@fofr fofr merged commit a122812 into master Apr 11, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the allow-worldwide-corp-info-previews branch Apr 11, 2017
@fofr fofr changed the title Set worldwide corporate informage page rendering_app to Whitehall Set worldwide corporate information page rendering_app to Whitehall Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.