Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lancaster House page #3321

Merged
merged 10 commits into from Jul 10, 2017
Merged

Update Lancaster House page #3321

merged 10 commits into from Jul 10, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 28, 2017

  • Add sections about significant rooms
  • Add images for rooms
  • Update contents list

Part of

https://trello.com/c/RTjN7sxI/
https://trello.com/c/NRxrJ33C/
https://govuk.zendesk.com/agent/tickets/2162306

Notes

  • The provided image for the grand hall and staircase is pixelated
  • Should we be including the map image, also low quality – we haven't included maps for other addresses

Before merging

  • Content reviewed
  • Zendesk ticket raiser reviewed

Screenshot

history of lancaster house - gov uk 20170628

cc @aledelcueto @nickcolley

aledelcueto and others added 9 commits Jun 23, 2017
Added h2s: 'The grand hall and staircase' and 'The long gallery'. Also made small changes to 'Introduction' and 'History'.
Added several sections: 'The music room', 'The state drawing room', 'The green room', 'The state dining room', 'The gold room', 'The eagle room'. Also updated contact information.
Added tags for images
Original images, not optimised or resized.
* Resize to 630px
* Optimise using JPEGMini

Images are all fairly detailed so filesize is still large
Delete old 300px image and replace with 300px resized version of large
external image
An address is sufficient detail for all other buildings and contact
details on GOV.UK.
@aledelcueto
Copy link
Contributor

@aledelcueto aledelcueto commented Jul 10, 2017

The department has reviewed the preview and they're asking for 2 changes (here's the zendesk ticket: https://govuk.zendesk.com/agent/tickets/2162306).

Please can I see a preview before you merge?

  1. 'Contact details' (bottom of the page)

REPLACE:
'Conference and Events Team, Lancaster House'

WITH:
Lancaster House enquiries

  1. Image of the music room

Add this image under the 'Music room' heading.
music_room_thumb

@aledelcueto
Copy link
Contributor

@aledelcueto aledelcueto commented Jul 10, 2017

Larger image:
music room

* Update contact name
* Add image of music room
@fofr fofr changed the title [Do not merge] Update Lancaster House page Update Lancaster House page Jul 10, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 10, 2017

Updated with new image and contact details:

history of lancaster house - gov uk 20170710

@fofr fofr merged commit 309dab4 into master Jul 10, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the lancaster-house branch Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.