Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing headings in HTML publications #3322

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 29, 2017

Depends on alphagov/govuk-content-schemas#631 (tests will fail until this is merged/deployed)
Follow up to alphagov/government-frontend#384

A follow-up PR should check whether the logic to calculate and store headers in Whitehall can be removed entirely.

@nickcolley @andysellick @rubenarakelyan

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jul 10, 2017

Maybe we should at a 'TODO' so someone in the future knows to investigate removing the underlying code?

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 10, 2017

Tests passing now alphagov/govuk-content-schemas#631 merged.

@fofr fofr requested a review from gpeng Jul 10, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 11, 2017

Code to stop heading generation can't be removed until this is completed:
https://trello.com/c/cLVn6spv/902-switch-html-publications-to-use-draft-stack-when-previewing-content

@gpeng
gpeng approved these changes Jul 13, 2017
@fofr fofr merged commit 5d5c116 into master Jul 13, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the stop-publishing-html-pub-headings branch Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.