Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete frontend parts of document collections #3335

Merged
merged 3 commits into from Jul 13, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 7, 2017

  • Document collections are rendered by government-frontend
  • The template and controller aren’t used
  • The route is still used to generate the base_path
  • Whitehall is still responsible for the /series redirect

Notes

fofr added 3 commits Jul 7, 2017
* Document collections are rendered by government-frontend
* The template and controller aren’t used
* The route is still used to generate the base_path
* Whitehall is still responsible for the `/series` redirect
* The preview of a document collection is now unavailable
* Go to the document collections tab of the editing screen in the index
view to make the same assertions
The collection can no longer be viewed directly
@fofr fofr requested a review from gpeng Jul 7, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 7, 2017

Ready to review. [Do not merge] flag is for more thorough testing with a branch deploy to Integration.

@fofr fofr mentioned this pull request Jul 7, 2017
5 of 6 tasks complete
@fofr fofr changed the title [Do not merge] Delete frontend parts of document collections Delete frontend parts of document collections Jul 10, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 10, 2017

Deployed to integration and tested previewing/creating/editing document collections.

@gpeng
gpeng approved these changes Jul 13, 2017
@fofr fofr merged commit dcaa8a4 into master Jul 13, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the delete-collections-frontend branch Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.