Ensure hidden files are migrated to asset manager #3658
We noticed that some assets in Whitehall have file names which include a leading dot These files are treated as "hidden" by Ruby's
In this PR I first refactor the tests for the migration code to allow me to more easily fix an issue with hidden NFS lock files that occurs when running the tests on the development VM on an OS X host. I then fix that issue. In the final commit I fix the issue described above.
We have already run the rake task against a number of directories. In a subsequent PR I'll introduce another task that ensures that any hidden files we've missed are also migrated.
referenced this pull request
Jan 4, 2018
floehopper left a comment
Minor: The formatting of the PR description and the commit note for the "Include hidden files when migrating to Asset Manager" commit makes them hard to read. I think it might be worth extracting the long hidden file path into a Markdown reference/footnote.
Minor: Using the "Fixes: " directive will close that issue when this PR is merged. Is that what you want to happen? I often keep the associated issue open until I've checked that stuff has been deployed/applied correctly in all environments and so I tend to avoid using those kind of directives.
I'm happy to leave it to you to decide how/whether to address my minor comments. Marking as approved.