Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash notice analytics tracking #3707

Merged
merged 1 commit into from Jan 23, 2018
Merged

Fix flash notice analytics tracking #3707

merged 1 commit into from Jan 23, 2018

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 23, 2018

As of govuk_admin_template v6 analytics events require a category. As this is not set, the event is not being registered in GA. This broke in #3219

https://github.com/alphagov/govuk_admin_template/blob/master/CHANGELOG.md#600
https://github.com/alphagov/govuk_admin_template/blob/master/app/assets/javascripts/govuk-admin-template/modules/auto_track_event.js

As of govuk_admin_template v6 analytics events require a category. As
this is not set, the event is not being registered in GA.

https://github.com/alphagov/govuk_admin_template/blob/master/CHANGELOG.m
d#600
https://github.com/alphagov/govuk_admin_template/blob/master/app/assets/
javascripts/govuk-admin-template/modules/auto_track_event.js
#3219
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 23, 2018

Not sure why this failed:

[build] Unable to find visible css ".conflicting.new #edition_title" (Capybara::ElementNotFound)
[build] ./features/step_definitions/document_steps.rb:220:in `/^I should see the conflict between the (publication|policy|news article|consultation|speech) titles "([^"]*)" and "([^"]*)"$/'
[build] features/speeches.feature:25:in `Then I should see the conflict between the speech titles "Ban Moustaches" and "Ban Beards"'
[build] 
[build] Failing Scenarios:
[build] cucumber features/speeches.feature:19 # Scenario: Trying to save a speech that has been changed by another user
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 23, 2018

Passing on 2nd attempt.

@fofr fofr requested review from andrewgarner and rubenarakelyan Jan 23, 2018
@fofr fofr merged commit b5523c7 into master Jan 23, 2018
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the add-analytics-tracking branch Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.