Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Number 10 virtual tour #3764

Merged
merged 2 commits into from Feb 9, 2018
Merged

Delete Number 10 virtual tour #3764

merged 2 commits into from Feb 9, 2018

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 9, 2018

Delete the flash tour from the Number 10 page, linking instead to Google’s version: https://www.google.com/culturalinstitute/beta/u/0/partner/10-downing-street

Deletes:

  • flash file
  • JS, CSS, XML and image files
  • content on Number 10 history page

Fixes #3632 Undoes #474

@fofr fofr requested a review from h-lame Feb 9, 2018
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Feb 9, 2018

Thanks so much for this Paul 👍

Flash superhero running up a building

@h-lame
h-lame approved these changes Feb 9, 2018
Copy link
Contributor

@h-lame h-lame left a comment

There's a remaining reference to the virtual tour in the Dockerfile - we can remove that too. I think the images referred to in the xml.erb files live on the server (a direct upload I think, 'cos they're not in this repo) so we might want to make a note somewhere to remove those too.

Other than that though, this looks goooooood!

GOVUK_ASSET_HOST was only used by the flash player
@fofr fofr merged commit dce88f2 into master Feb 9, 2018
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
@fofr fofr deleted the delete-tour branch Feb 9, 2018
@edwardhorsford
Copy link
Contributor

@edwardhorsford edwardhorsford commented Feb 9, 2018

Yay thanks @fofr!

@joelanman
Copy link
Member

@joelanman joelanman commented Feb 9, 2018

Great work everyone, really appreciate theres a replacement

@chrisroos
Copy link
Contributor

@chrisroos chrisroos commented Feb 12, 2018

I think the images referred to in the xml.erb files live on the server (a direct upload I think, 'cos they're not in this repo) so we might want to make a note somewhere to remove those too.

These images have been migrated to Asset Manager so will need to be deleted from there if required.

@chrislo
Copy link
Contributor

@chrislo chrislo commented Feb 12, 2018

See: alphagov/asset-manager#268. Note these URLs are still valid so you'd have to put some redirects if you deleted the assets.

@h-lame
Copy link
Contributor

@h-lame h-lame commented Feb 12, 2018

I think there aren't really any useful places we could redirect someone requesting one of those images. For example: some of them are UI elements for the player, whereas others are the texture skins of the rooms for the player, but they're not flat photos so they need the player to interpret and deform them to be viewable properly. Probably we'd just 410 them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.