Add new "force publish anything" permission #401

Merged
merged 2 commits into from Apr 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

h-lame commented Mar 27, 2013

This allows any user the ability to force publish any edition. Note that it doesn't escalate any other permissions, so they still can't see anything they wouldn't normally be allowed to see. This is intended to be added to the user account used by the force publisher for imports who doesn't need to be able to login and do things, just force publish everything in an import batch. There's a data migration that adds this permission to that user.

For: https://www.pivotaltracker.com/story/show/46979963

Contributor

bradwright commented Mar 27, 2013

test_validation_errors_when_reordering_features_are_propogated failed, but that test seems flakey (it failed on another unrelated branch as well).

Contributor

h-lame commented Mar 28, 2013

Rebasing (NOTE: that test doesn't fail locally).

h-lame added some commits Mar 27, 2013

Add new permission to allow force publishing anything
In the edition rules, if the action is force_publish and the actor can_force_publish_anything? return true immediately.  This is so that the robot account used during force publish process for an import is able to force publish stuff.  I didn't want to add a full on "can do anything" permission, hence the limited scope of this.

heathd added a commit that referenced this pull request Apr 2, 2013

@heathd heathd merged commit 5b36b37 into master Apr 2, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment