Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a redirect for announcements atom feed #4855

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
3 participants
@SamJamCul
Copy link
Contributor

commented Jun 18, 2019

This change introduces a redirect in the announcements finder
controller. When going to an announcements finder atom feed,
this checks to see if the locale selected is English, and if so it will
redirect to the news and comms finder atom feed instead.

Tests have also been removed/added to account for this, but there might be some missing feature tests that should be included.

This is part of this card, and thanks to @koetsier for helping!

@SamJamCul SamJamCul force-pushed the redirect-announcements-atom-feed branch from e471eca to 5e323f7 Jun 18, 2019

@bilbof

bilbof approved these changes Jun 18, 2019

Copy link
Contributor

left a comment

🎉

Adds a redirect for announcements atom feed
This change introduces a redirect in the announcements finder
controller. When going to an announcements finder atom feed,
this checks to see if the locale selected is English, and if so it will
redirect to the news and comms finder atom feed instead.

@SamJamCul SamJamCul force-pushed the redirect-announcements-atom-feed branch from 5e323f7 to 086c52a Jun 18, 2019

@SamJamCul SamJamCul merged commit 59457dd into master Jun 18, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details

@bilbof bilbof deleted the redirect-announcements-atom-feed branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.