Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix inline attachment rendering #5237
Removes trailing newlines from inline attachment view. There were two things causing the additional space:
There is a bug where an additional space is being added after the name of an inline attachment, e.g. ``` Download and fill in the [InlineAttachment:1]. ``` renders as ``` Download and fill in the registration form (ODS, 16.9KB) . ``` This test will allow us to find the problem.
The repeated spaces following the new line characters are being rendered by web browsers as a single space, leading to: ``` Download and fill in the [InlineAttachment:1]. ``` being rendered as ``` Download and fill in the registration form (ODS, 16.9KB) . ```
vanitabarrett merged commit
Jan 7, 2020
3 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.