New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit-todos-update hangs on MacOS #54

Closed
smaret opened this Issue Sep 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@smaret

smaret commented Sep 7, 2018

magit-todos looks like a very nice emacs package, but I can't get it to work on my computer (Mac OS 10.13.2, Emacs 26.1, magit-todos 20180904.1753 installed from MELPA).

I've turn on the magit-todos-mode in the magit buffer for my project. Typing j-T displays: "No TODOs section". Then when I try to update the list manually with magit-todos-update Emacs hangs.

I've installed both ripgrep and git grep and the method is set to "Automatic".

@smaret smaret changed the title from `magit-todos-update` hangs to magit-todos-update hangs on MacOS Sep 7, 2018

@alphapapa

This comment has been minimized.

Show comment
Hide comment
@alphapapa

alphapapa Sep 7, 2018

Owner

Hi Sebastien,

Typing j-T displays: "No TODOs section"

I guess that means that you opened the magit-status buffer and then enabled magit-todos-mode. It's intended that you enable magit-todos-mode (which is global, not buffer-local) and then open the magit-status buffer. But in case you do it that way, if you refresh the magit-status buffer by pressing g, it should work then.

Owner

alphapapa commented Sep 7, 2018

Hi Sebastien,

Typing j-T displays: "No TODOs section"

I guess that means that you opened the magit-status buffer and then enabled magit-todos-mode. It's intended that you enable magit-todos-mode (which is global, not buffer-local) and then open the magit-status buffer. But in case you do it that way, if you refresh the magit-status buffer by pressing g, it should work then.

alphapapa added a commit that referenced this issue Sep 7, 2018

@alphapapa alphapapa closed this in bba449f Sep 7, 2018

@alphapapa

This comment has been minimized.

Show comment
Hide comment
@alphapapa

alphapapa Sep 7, 2018

Owner

I made a couple of fixes to avoid the loop and tell the user that the mode should be activated first. Thank you for reporting this issue.

Owner

alphapapa commented Sep 7, 2018

I made a couple of fixes to avoid the loop and tell the user that the mode should be activated first. Thank you for reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment