Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-web-tools-insert-link-for-url fails for https://youtu.be links #67

Closed
hubisan opened this issue Dec 15, 2023 · 4 comments
Closed

org-web-tools-insert-link-for-url fails for https://youtu.be links #67

hubisan opened this issue Dec 15, 2023 · 4 comments
Assignees
Labels

Comments

@hubisan
Copy link

hubisan commented Dec 15, 2023

org-web-tools-insert-link-for-url fails when attempting to insert a YouTube link obtained from the 'share' button using the org-web-tools-insert-link-for-url. Those links are redirecting ones: https://youtu.be

If it fails, it shows the html retrieved in the message buffer. That message actually includes the title.

Maybe I am doing something wrong or it is due to my network settings, not sure.

@alphapapa
Copy link
Owner

Thanks for reporting this. The problem is that I omitted the 303 response code in plz: https://github.com/alphapapa/plz.el/blob/e8440857e5500ae3f223afa7bd90263abf5c4df3/plz.el#L829 I'll soon make a bug-fix release to plz with that fix, but I'm waiting on an update to the ELPA package definition so I can release it as v0.7.1.

@alphapapa alphapapa self-assigned this Dec 16, 2023
alphapapa added a commit to alphapapa/plz.el that referenced this issue Dec 18, 2023
@alphapapa
Copy link
Owner

Fixed in plz v0.7.1 and on master. Thanks.

@hubisan
Copy link
Author

hubisan commented Dec 18, 2023

Do you not have to adapt the plz version in the package header?

;; Package-Requires: ((emacs "27.1") (org "9.0") (compat "29.1.4.2") (dash "2.12") (esxml "0.3.4") (s "1.10.0") (plz "0.7") (request "0.3.0"))

alphapapa added a commit that referenced this issue Dec 19, 2023
@alphapapa
Copy link
Owner

Well, doing so won't force any existing users to upgrade either package. But it might help ensure that new users get the newer version, so we might as well, yes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants