Tests: Fix ideal value for leap year length in seconds being off #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the test doesn't support leap seconds, a normal leap year
should still be 31622400 seconds.
(* 60 60 24 366) ;=> 31622400
|
Thanks! Came across with the same issue. |
|
@kisaragi-hiu Thanks for your patience, and for the fix. I don't know how I made that mistake in the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts.el/test/test.el
Lines 445 to 446 in df48734
Although the test doesn't take leap seconds into account, a normal leap year should still be 31622400 (60 seconds * 60 minutes * 24 hours * 366 days) seconds long.