From 8815649a087404bb8ab3ed4953a53c660091d3c7 Mon Sep 17 00:00:00 2001 From: Bridget Almas Date: Mon, 2 Feb 2015 10:39:32 -0500 Subject: [PATCH] Revert "Analytics error events" --- app/js/arethusa.core/arethusa_ctrl.js | 3 +-- app/js/arethusa/global_error_handler.js | 34 ------------------------- 2 files changed, 1 insertion(+), 36 deletions(-) delete mode 100644 app/js/arethusa/global_error_handler.js diff --git a/app/js/arethusa.core/arethusa_ctrl.js b/app/js/arethusa.core/arethusa_ctrl.js index ff56d28a6..14d877634 100644 --- a/app/js/arethusa.core/arethusa_ctrl.js +++ b/app/js/arethusa.core/arethusa_ctrl.js @@ -1,6 +1,5 @@ 'use strict'; angular.module('arethusa.core').controller('ArethusaCtrl', [ - 'GlobalErrorHandler', '$scope', 'configurator', 'state', @@ -12,7 +11,7 @@ angular.module('arethusa.core').controller('ArethusaCtrl', [ 'translator', '$timeout', 'globalSettings', - function (GlobalErrorHandler, $scope, configurator, state, documentStore, notifier, + function ($scope, configurator, state, documentStore, notifier, saver, history, plugins, translator, $timeout, globalSettings) { // This is the entry point to the application. diff --git a/app/js/arethusa/global_error_handler.js b/app/js/arethusa/global_error_handler.js deleted file mode 100644 index be14b9d19..000000000 --- a/app/js/arethusa/global_error_handler.js +++ /dev/null @@ -1,34 +0,0 @@ -"use strict"; - -angular.module('arethusa').factory('GlobalErrorHandler', [ - '$window', - '$analytics', - function($window, $analytics) { - var oldErrorHandler = $window.onerror; - $window.onerror = function errorHandler(errorMessage, url, lineNumber) { - var trace = printStackTrace(); - $analytics.eventTrack(errorMessage + " @" + url + " : " + lineNumber, { - category: 'error', label: trace.join(', ') - }); - - if (oldErrorHandler) - return oldErrorHandler(errorMessage, url, lineNumber); - - return false; - }; - } -]); - -angular.module('arethusa').factory('$exceptionHandler', [ - '$analytics', - '$log', - function($analytics, $log) { - return function errorHandler(exception, cause) { - $log.error.apply($log, arguments); - var trace = printStackTrace(); - $analytics.eventTrack(exception + ': ' + cause, { - category: 'error', label: trace.join(', ') - }); - }; - } -]);