Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve x-for reactivity #165

Closed
wants to merge 5 commits into from

Conversation

SimoTod
Copy link
Collaborator

@SimoTod SimoTod commented Feb 7, 2020

Alternative solution for #144 using defineProperty + setter and getter (Ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#Custom_Setters_and_Getters) instead of another proxy item.

The same considerations I made for #151 about the spread operator applies to this PR: the spread operator doesn't copy properties into the new object, only normal variables.

Performance (time and memory) will improve slightly as well since we are not going to create the same copy of an object 2-3 times.

@SimoTod
Copy link
Collaborator Author

SimoTod commented Mar 7, 2020

Updated to support the last release. Feel free to close it if not useful.

@calebporzio
Copy link
Collaborator

Going to hold off on this for now. However, I will add this PR to the v3 roadmap so we can use the contributed test to test against the new reactivity engine. Thanks!

@SimoTod SimoTod deleted the feature/x-for-patch-v2 branch November 20, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants