Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining reproducible builds issues in abuild #110

Closed
wants to merge 2 commits into from

Conversation

@kpcyrd
Copy link
Contributor

kpcyrd commented Dec 17, 2019

  • ensures that gzip -n is always used
  • normalizes atime and ctime in tar metadata
  • explicitly sort the files instead of relying on the order returned by readdir(2)
@mor1

This comment has been minimized.

Copy link
Contributor

mor1 commented Dec 18, 2019

I haven't been able to test but this looks sensible to me :)
I guess it's too late to merge for the current release though (currently at rc3 I believe).

@kpcyrd

This comment has been minimized.

Copy link
Contributor Author

kpcyrd commented Dec 18, 2019

Sure, I think it was already to late to merge when I wrote this patch. :)

We're currently using an abuild with this patch applied at https://tests.reproducible-builds.org/alpine/alpine.html

@algitbot

This comment has been minimized.

Copy link

algitbot commented Jan 30, 2020

Merged in 660f793, 4f5b0a1 by @ncopa. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jan 30, 2020
@ncopa

This comment has been minimized.

Copy link
Contributor

ncopa commented Jan 30, 2020

merged with 660f793 and 4f5b0a1. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.