Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/wireguard: update to 0.0.20170320 #1055

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@itoffshore
Copy link
Contributor

commented Mar 20, 2017

  • wireguard-grsec
  • wireguard-vanilla
  • wireguard-tools

@itoffshore itoffshore force-pushed the itoffshore:wireguard branch 2 times, most recently from 5db9c55 to 95e1253 Mar 20, 2017

@jirutka

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

Why is wiredguard split into three separated abuilds instead of one with three subpackages?

@itoffshore

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2017

because 2 are kernel modules - it's packaged the same way as zfs

@@ -7,7 +7,7 @@ _kver=4.9.16
_kpkgrel=0

# when changing _ver we *must* bump _mypkgrel
_ver=0.0.20170223
_ver=0.0.20170320

This comment has been minimized.

Copy link
@ncopa

ncopa Mar 22, 2017

Contributor

comment says that when _ver changes we must increase _mypkgrel.

This comment has been minimized.

Copy link
@itoffshore

itoffshore Mar 22, 2017

Author Contributor

fixed & rebased

@@ -7,7 +7,7 @@ _kver=4.9.16
_kpkgrel=0

# when changing _ver we *must* bump _mypkgrel
_ver=0.0.20170223
_ver=0.0.20170320
_mypkgrel=0

This comment has been minimized.

Copy link
@ncopa

ncopa Mar 22, 2017

Contributor

needs to be _mypkgrel=1

This comment has been minimized.

Copy link
@itoffshore

itoffshore Mar 22, 2017

Author Contributor

fixed & rebased

@ncopa

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2017

3 packages is fine. The kernel modules should be built with kernel and the userspace tool should be separate so it can be shared with the different kernels.

I wonder if we should rename wireguard-tools to wireguard. Upstream source package is called Wireguard. We'd also need change the install_if="wireguard-tools linux-grsec-$_kver" to install_if="wireguard linux-grsec-$_kpkgver" (the $_kver there should be $_kpkgver btw)

That way apk add wireguard would install the userspace package and the kernel package(s) for the installed kernel(s).

@itoffshore itoffshore force-pushed the itoffshore:wireguard branch from 5cd6fd3 to 97579e9 Mar 22, 2017

@itoffshore

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2017

Debian & Arch have both named the userspace as wireguard-tools too.

  • $_mypkgrel bumped
  • $install_if fixed
@algitbot

This comment has been minimized.

Copy link

commented Mar 23, 2017

Merged in 01332ec, b70e44d, 1adeeda by @ncopa. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Mar 23, 2017

@itoffshore itoffshore deleted the itoffshore:wireguard branch Mar 23, 2017

@ncopa

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2017

@itoffshore this failed on aarch64. Do you think you could report it upstream?

  CC [M]  /home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/compat/siphash/siphash.o
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c: In function 'curve25519':
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:478:6: error: 'curve25519_use_avx' undeclared (first use in this function)
  if (curve25519_use_avx && irq_fpu_usable()) {
      ^~~~~~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:478:6: note: each undeclared identifier is reported only once for each function it appears in
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:478:28: error: implicit declaration of function 'irq_fpu_usable' [-Werror=implicit-function-declaration]
  if (curve25519_use_avx && irq_fpu_usable()) {
                            ^~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:479:3: error: implicit declaration of function 'kernel_fpu_begin' [-Werror=implicit-function-declaration]
   kernel_fpu_begin();
   ^~~~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:480:3: error: implicit declaration of function 'curve25519_sandy2x' [-Werror=implicit-function-declaration]
   curve25519_sandy2x(mypublic, secret, basepoint);
   ^~~~~~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:481:3: error: implicit declaration of function 'kernel_fpu_end' [-Werror=implicit-function-declaration]
   kernel_fpu_end();
   ^~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c: In function 'curve25519_generate_public':
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:505:6: error: 'curve25519_use_avx' undeclared (first use in this function)
  if (curve25519_use_avx && irq_fpu_usable()) {
      ^~~~~~~~~~~~~~~~~~
/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.c:507:3: error: implicit declaration of function 'curve25519_sandy2x_base' [-Werror=implicit-function-declaration]
   curve25519_sandy2x_base(pub, secret);
   ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:294: /home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src/crypto/curve25519.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1490: _module_/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-4.9.17'
make: *** [Makefile:28: module] Error 2
make: Leaving directory '/home/buildozer/aports/testing/wireguard-vanilla/src/WireGuard-0.0.20170320.1/src'
>>> ERROR: wireguard-vanilla: all failed
@itoffshore

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2017

ok will contact the mailing list & ping to @zx2c4

@zx2c4

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2017

Known issue. It'll be fixed in the next snapshot. Sorry about that.

@zx2c4

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2017

20170324 has been released, which fixes this issue.

@itoffshore

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2017

@zx2c4 many thx for the prompt response - @ncopa PR to update to 0.0.20170324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.