Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/unixodbc: Add static linking support #12004

Closed
wants to merge 1 commit into from

Conversation

@palfrey
Copy link
Contributor

palfrey commented Oct 27, 2019

No description provided.

@project-bot project-bot bot added this to To Do in Triage Oct 27, 2019
@probot-autolabeler probot-autolabeler bot added the R-main label Oct 27, 2019
@maxice8

This comment has been minimized.

Copy link
Contributor

maxice8 commented Nov 2, 2019

please add a $pkgname-static subpackage, have it declared on the subpackages= variable before $pkgname-dev

>>> WARNING: unixodbc-dev*: Found static archive on usr/lib/libodbccr.a but name doesn't end with -static
2173	>>> WARNING: unixodbc-dev*: Found static archive on usr/lib/libodbc.a but name doesn't end with -static
2174	>>> WARNING: unixodbc-dev*: Found static archive on usr/lib/libodbcinst.a but name doesn't end with -static
@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Nov 2, 2019

@maxice8 Done

@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Nov 5, 2019

@maxice8 Is there anything else you need me to do for this? My first PR here, and I'm not entirely certain about the process!

@maxice8

This comment has been minimized.

Copy link
Contributor

maxice8 commented Nov 5, 2019

If you could squash all the commits into one it would be good to go, unfortunately i don't have permission to push changes to main/ so you'll have to wait for someone who does, which is a smaller group.

@palfrey palfrey force-pushed the palfrey:unixodbc-static branch from 505f204 to 3a7d8d4 Nov 5, 2019
@palfrey palfrey mentioned this pull request Nov 16, 2019
2 of 2 tasks complete
@algitbot

This comment has been minimized.

Copy link

algitbot commented Nov 19, 2019

Merged in 625e554 by @maxice8. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Nov 19, 2019
Triage automation moved this from To Do to Done Nov 19, 2019
@palfrey palfrey deleted the palfrey:unixodbc-static branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.