Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-firmware: split up in subpackages #3037

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@ollieparanoid
Copy link
Contributor

commented Jan 8, 2018

This PR splits up the > 250 MB install size linux-firmware package in one package for each /lib/firmware subfolder (linux-firmware-liquido (23.7 MB), linux-firmware-netrome (22.0 MB), ...). Files directly in /lib/firmware are now in "linux-firmware-other" (~100 MB), and the "linux-firmware" package depends on all its subpackages for compatibility.

The other() function always gets called as last subpackage function, and it checks that all folders in /lib/firmware have been moved to subpackages. If that is not the case, it proposes a new _folders variable and fails the build:

>>> linux-firmware-other*: Running split function other...
>>> ERROR: linux-firmware-other*: Not all subfolders have been moved to subpackages!
>>> ERROR: linux-firmware-other*: Fix this by adjusting _folders as follows:
_folders="3com RTL8192E acenic adaptec advansys amd-ucode amdgpu ar3k ath10k
ath6k ath9k_htc atmel atusb av7110 bnx2 bnx2x brcm carl9170fw cavium cis cpia2
cxgb3 cxgb4 dabusb dsp56k e100 edgeport emi26 emi62 ene-ub6250 ess go7007 i915
imx intel isci kaweth keyspan keyspan_pda korg libertas liquidio matrox
mellanox moxa mrvl mwl8k mwlwifi myricom netronome nvidia ositech qca qcom qed
qlogic r128 radeon rockchip rsi rtl_bt rtl_nic rtlwifi sb16 slicoss sun sxg
tehuti ti-connectivity ti-keystone tigon ttusb-budget ueagle-atm vicam vxge yam
yamaha"
>>> ERROR: linux-firmware-other*: other failed
>>> ERROR: linux-firmware*: prepare_subpackages failed
>>> ERROR: linux-firmware: all failed

(See also: https://lists.alpinelinux.org/alpine-devel/6005.html)

@algitbot

This comment has been minimized.

Copy link

commented Jan 8, 2018

Merged in 133ebbc by @kaniini. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jan 8, 2018

@jirutka

This comment has been minimized.

Copy link
Member

commented Jan 9, 2018

This is not backward compatible and does not warn user on upgrade that (s)he must install some subpackages now.

@ollieparanoid ollieparanoid deleted the ollieparanoid:patch-2 branch Jan 9, 2018

@ollieparanoid

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2018

Why is this not backwards compatible? linux-firmware depends on all its subpackages.
Follow-up PR: #3046

@jirutka

This comment has been minimized.

Copy link
Member

commented Jan 9, 2018

Why is this not backwards compatible? linux-firmware depends on all its subpackages.

Mea culpa, you’re right. I reviewed it from a mobile phone and overlooked that. Sorry for confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.