Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/vips: upgrade to 8.7.4 #6074

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@lovell
Copy link
Contributor

commented Jan 18, 2019

@andypost andypost added the A-upgrade label Jan 19, 2019

@andypost

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

Makes sense to improve package a bit

-depends_dev="libjpeg-turbo-dev libexif-dev lcms2-dev"
-makedepends="$depends_dev fftw-dev giflib-dev glib-dev libpng-dev libwebp-dev
-       expat-dev orc-dev tiff-dev"
+makedepends="expat-dev fftw-dev giflib-dev glib-dev lcms2-dev
+       libexif-dev libjpeg-turbo-dev libpng-dev libwebp-dev
+       orc-dev tiff-dev"

That's could be found in travis build log

>>> vips-dev*: Tracing dependencies...
>>> WARNING: vips-dev*: lcms2-dev should be removed from depends_dev
>>> WARNING: vips-dev*: libexif-dev should be removed from depends_dev
>>> WARNING: vips-dev*: libjpeg-turbo-dev should be removed from depends_dev
	libjpeg-turbo-dev
	libexif-dev
	lcms2-dev
	pc:fftw3
	pc:glib-2.0
	pc:gmodule-2.0
	pc:gobject-2.0
	pc:lcms2
	pc:libexif
	pc:libjpeg
	pc:libpng
	pc:libtiff-4
	pc:libwebp
	pc:libwebpmux
	pc:orc-0.4
	pc:zlib
	pkgconfig
	vips=8.7.4-r0
@andypost

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

configure: WARNING: unrecognized options: --without-python
>>> WARNING: vips: APKBUILD does not run any tests!
    Alpine policy will soon require that packages have any relevant testsuites run during the build process.
    To fix, either define a check() function, or declare !check in $options to indicate the package does not have a testsuite.
@andypost

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

added check() shows locally

Testsuite summary for vips 8.7.4
============================================================================
# TOTAL: 4
# PASS:  2
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

$ cat src/vips-8.7.4/test/test-suite.log
=====================================
   vips 8.7.4: test/test-suite.log
=====================================

# TOTAL: 4
# PASS:  2
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test_cli.sh
=================

testing with йцук.jpg
testing nearest ... ./test_cli.sh: line 26: bc: not found
difference is 0.000000
FAIL test_cli.sh (exit status: 1)

FAIL: test_formats.sh
=====================

testing йцук.jpg v ... ./test_formats.sh: line 63: bc: not found
save / load difference is 0.000000
FAIL test_formats.sh (exit status: 1)

@algitbot

This comment has been minimized.

Copy link

commented Jan 19, 2019

Merged in 1afdad0 by @andypost. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jan 19, 2019

@lovell lovell deleted the lovell:testing-vips-8.7.4 branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.