Skip to content

testing/git-crypt: new aport - #7070

Closed
spk wants to merge 2 commits into
alpinelinux:masterfrom
spk:testing/git-crypt
Closed

testing/git-crypt: new aport#7070
spk wants to merge 2 commits into
alpinelinux:masterfrom
spk:testing/git-crypt

Conversation

@spk

@spk spk commented Apr 13, 2019

Copy link
Copy Markdown
Contributor

Hi,

First packaging for alpine adding git-crypt transparent file encryption in git

Url: https://github.com/AGWA/git-crypt
Description: Transparent file encryption in git

Cheers,
Laurent

Comment thread testing/git-crypt/APKBUILD Outdated
license="GPL-3.0-or-later"
depends="git"
makedepends="openssl-dev docbook-xml docbook-xsl"
install=""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed when not used.

Suggested change
install=""

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fixed in 720d0ec

Comment thread testing/git-crypt/APKBUILD Outdated
arch="all"
license="GPL-3.0-or-later"
depends="git"
makedepends="openssl-dev docbook-xml docbook-xsl"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical order.

Suggested change
makedepends="openssl-dev docbook-xml docbook-xsl"
makedepends="docbook-xml docbook-xsl openssl-dev"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fixed in 720d0ec

Comment thread testing/git-crypt/APKBUILD Outdated

package() {
cd "$builddir"
make PREFIX="$pkgdir/usr" ENABLE_MAN=yes install

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit funky to me. Normally the prefix and options are given to make during the build phase and install is only given DESTDIR.

https://github.com/AGWA/git-crypt/blob/master/Makefile

Suggested change
make PREFIX="$pkgdir/usr" ENABLE_MAN=yes install
make DESTDIR="$pkgdir" ENABLE_MAN=yes install

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not install properly with just your suggestion so I had to do make PREFIX="/usr" DESTDIR="$pkgdir" ENABLE_MAN=yes install in 720d0ec

Comment thread testing/git-crypt/APKBUILD Outdated

build() {
cd "$builddir"
make ENABLE_MAN=yes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make ENABLE_MAN=yes
make PREFIX="/usr"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url="https://www.agwa.name/projects/git-crypt"
arch="all"
license="GPL-3.0-or-later"
depends="git"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable check since no test suite is available.

Suggested change
depends="git"
depends="git"
options="!check" # No test suite

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done in 720d0ec


check() {
cd "$builddir"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check function can be removed since it is not used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok done in 720d0ec

@Ikke Ikke added the R-testing Testing repository label Apr 14, 2019
@algitbot

Copy link
Copy Markdown

Merged in 8d20bb2 by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Apr 14, 2019
@tcely tcely added the A-new Adds a new aport package label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-new Adds a new aport package R-testing Testing repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants