Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign uptesting/wireguard: various small fixes #954
Conversation
itoffshore
referenced this pull request
Mar 2, 2017
Closed
testing/wireguard-grsec / wireguard-vanilla / wireguard-tools #948
This comment has been minimized.
This comment has been minimized.
|
note to @zx2c4 |
zx2c4
reviewed
Mar 3, 2017
testing/wireguard-tools/APKBUILD
Outdated
| @@ -45,7 +43,7 @@ bashcomp() { | |||
| } | |||
|
|
|||
| tests() { | |||
This comment has been minimized.
This comment has been minimized.
zx2c4
Mar 3, 2017
Contributor
This "tests package" simply will not work out of context like this. It does not belong in a distribution package, no matter what it's called. If misunderstandings like this become more widespread than just you, then I wouldn't hesitate to just remove the code from the repository. It really doesn't belong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
itoffshore
force-pushed the
itoffshore:wireguard
branch
from
516514c
to
ab7273d
Mar 3, 2017
This comment has been minimized.
This comment has been minimized.
|
Latest commit looks good to me. Please merge! |
itoffshore
force-pushed the
itoffshore:wireguard
branch
4 times, most recently
from
065c723
to
715c4c4
Mar 3, 2017
itoffshore
added some commits
Mar 3, 2017
itoffshore
force-pushed the
itoffshore:wireguard
branch
from
715c4c4
to
5fa06d8
Mar 3, 2017
This comment has been minimized.
This comment has been minimized.
algitbot
commented
Mar 4, 2017
|
Merged in 6a64106, 9511bca, 7fb3103 by @kaniini. Thanks for your contribution! (This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.) |
algitbot
closed this
Mar 4, 2017
itoffshore
deleted the
itoffshore:wireguard
branch
Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
itoffshore commentedMar 2, 2017
•
edited
$install_ifso the kernel modules install automatically when addingwireguard-toolsmake checkremoved &sparseremoved frommakedependsat the request of the author