Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Edge` logo #180

Closed

Conversation

@jonathantneal
Copy link
Contributor

jonathantneal commented Nov 4, 2019

Here is the new logo for Edge in SVG format, courtesy of Tom Warren of The Verge.

I think this is technically my first PR to this repo. Would you let me know if I need to update anything? I’m excited to finally contribute!

Resolves #179

@jonathantneal jonathantneal requested a review from alrra as a code owner Nov 4, 2019
src/edge/edge.svg Outdated Show resolved Hide resolved
@XhmikosR XhmikosR referenced this pull request Nov 4, 2019
src/edge_13-79/package.json Outdated Show resolved Hide resolved
@alrra

This comment has been minimized.

Copy link
Owner

alrra commented Nov 4, 2019

I’m excited to finally contribute!

@jonathantneal 🎉

@foolip

This comment has been minimized.

Copy link

foolip commented Nov 4, 2019

Are there beta, dev and canary variants yet?

@jonathantneal

This comment has been minimized.

Copy link
Contributor Author

jonathantneal commented Nov 4, 2019

@foolip, no, this PR focuses on the icon seen in the easter egg surf game in Chrome Canary 80, which has been announced as the new icon of the browser.

@alrra

This comment has been minimized.

Copy link
Owner

alrra commented Nov 4, 2019

Are there beta, dev and canary variants yet?

@foolip I was talking with @kypflug and he said he will send them to me as soon as he has them.


From https://blogs.windows.com/msedgedev/2019/11/04/edge-chromium-release-candidate-get-ready/#gve7ejwW9tcXVRam.97:

@foolip

This comment has been minimized.

Copy link

foolip commented Nov 4, 2019

Those are very nice!

@codepo8

This comment has been minimized.

Copy link

codepo8 commented Nov 4, 2019

Here are the high-res ones for the different channels
Edge_CanAppList targetsize-1024
Edge_DevAppList targetsize-1024
Edge_BetaAppList targetsize-1024

And the high contrast one:

For light backgrounds:
EdgeAppList targetsize-256_altform-lightunplated_contrast-white

For dark backgrounds
EdgeAppList targetsize-256_altform-lightunplated_contrast-black

@jonathantneal

This comment has been minimized.

Copy link
Contributor Author

jonathantneal commented Nov 4, 2019

@codepo8 Awesome! Those look great!

Think you might get your hands on SVG copies? I guess if we know the typeface we can take the logo svg and create those badge versions ourselves. But we would probably need real SVGs for those stylish monochromes.

@codepo8

This comment has been minimized.

Copy link

codepo8 commented Nov 4, 2019

Not yet, that'd be Kyle's doing.

@alrra alrra changed the title Update edge logo Add `Edge` logo Nov 5, 2019
Copy link
Owner

alrra left a comment

@jonathantneal Thank you for the pull request, and congrats on your first contribution! 🎉

I've merged the PR with some changes.

src/edge/edge.svg Show resolved Hide resolved
src/edge_12-18/package.json Show resolved Hide resolved
src/edge/edge.svg Show resolved Hide resolved
@alrra alrra closed this in 82c7d89 Nov 5, 2019
@alrra

This comment has been minimized.

Copy link
Owner

alrra commented Nov 5, 2019

Thank you @kypflug and @codepo8!

@jonathantneal jonathantneal deleted the jonathantneal:feature/new-edge-logo branch Nov 5, 2019
@scribblemaniac

This comment has been minimized.

Copy link
Contributor

scribblemaniac commented Nov 16, 2019

@alrra Here are SVG versions of the high contrast logos: edge-high-contrast.zip

They are not the official versions. They were traced from the images above with Inkscape, but given how simple these logos are they should be almost exactly the same, and in my opinion are good enough to be included in this repo.

@jonathantneal

This comment has been minimized.

Copy link
Contributor Author

jonathantneal commented Nov 16, 2019

@scribblemaniac, did you create this from the SVGs for the PNGs? I see interupted curves when I view those SVGs.

image

image

@scribblemaniac

This comment has been minimized.

Copy link
Contributor

scribblemaniac commented Nov 16, 2019

@jonathantneal Good catch. Yes I created them from the PNGs, but it does do a lot of guesswork so stuff like that does happen. I've tweaked the settings (apparently there is a good reason that the default brightness cutoff is 0.45 and not 0.5), and it seems to have fixed the issue. Here are the updated files: edge-high-contrast-2.zip

edge-1

edge-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.