Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes bug when generating publications from single authors. #27
There currently is a bug when generating the author field for single-author publications: an "and" is added in front of the name of the author (as in the demo, where we have "and Einstein, Albert", see here).
This PR fixes it with with some minimal changes in
alshedivat left a comment
Thanks for the fix! I have no idea how I missed that dangling "and."
Your fix seems to introduce "and" between any pair of consecutive authors, not just before the last author. Not sure how I feel about it. How about we just remove "and" entirely? Thanks.
I had to rewrite the Liquid loop, but I think it is fixed now. The comma is still added before the "and" (i.e., "A, B, and C", an Oxford comma), which I personally prefer, but this could be changed (the loop would get a bit more complex, but this is probably due to my lack of experience with Liquid)
…source * 'master' of https://github.com/alshedivat/al-folio: (38 commits) Make google analytics conditional (alshedivat#63) Enable preview images on social media (alshedivat#66) Add social buttons: Publons, ResearchGate and Blogger (alshedivat#65) Make the display of an email conditional Include link and pdf in bib Added css to take account of vertical scroll bar and avoid content jumps Update _config.yml Added quora and medium to social move image-row height and col to media queries to adjust with viewport Fixes bug when generating publications from single authors. (alshedivat#27) Do not delete CNAME when moving _site files to deploy branch (alshedivat#25) Minor formatting Add Travis CI (alshedivat#21) Changed `baseurl` property of `_config.yml` back to /al-folio and minor edit to `README` for consistency with the al-folio master branch Fixed webkit text scaling `bug` Removed profile align property completely Added left class to all images Removed align:left from col class Removed !important flag from profile class alignment Bump license year to 2018 ...