Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google analytics conditional #63

Merged

Conversation

@g-oikonomou
Copy link
Contributor

g-oikonomou commented Nov 1, 2019

Thanks for sharing this work. I just started using it for g-oikonomou.github.io

This pull makes the inclusion of google analytics conditional.

Copy link
Owner

alshedivat left a comment

Looks great, thanks for the contribution! There's one minor comment, and it'll be ready to merge.

_includes/hemline.html Outdated Show resolved Hide resolved
Copy link
Owner

alshedivat left a comment

LGTM. Thanks!

@alshedivat alshedivat merged commit ad39d02 into alshedivat:master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@g-oikonomou g-oikonomou deleted the g-oikonomou:contrib/conditional-google-analytics branch Nov 4, 2019
dylanashley added a commit to dylanashley/dylanashley.github.io that referenced this pull request Nov 30, 2019
* Make google analytics conditional

* Move comment inside the if conditional
 [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.