Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support context on functional element #10

Closed
wants to merge 2 commits into from

Conversation

arypurnomoz
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Nov 14, 2016

Coverage Status

Coverage remained the same at 98.137% when pulling e5d938c on arypurnomoz:master into 1257a8e on alt-j:master.

Copy link
Owner

@alt-j alt-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add some test for that

return renderElement(type(props));
return renderElement(
type(props, (options && options.context) || {}),
options && options.context ? {context: options.context} : null
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here the condition is optional, you can always pass options

@alt-j alt-j mentioned this pull request Dec 9, 2016
@alt-j
Copy link
Owner

alt-j commented Dec 9, 2016

7fce20a

@alt-j alt-j closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants