Isvalidelement #24
Merged
Isvalidelement #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt-j
requested changes
Feb 14, 2017
src/index.js
Outdated
| }, | ||
|
|
||
| /** | ||
| * @param {RenderElement} element |
There was a problem hiding this comment.
This method can take any type of argument.
src/index.js
Outdated
| */ | ||
| isValidElement: function (element) { | ||
| return element === null || | ||
| (typeof element === 'object' && typeof element.type !== 'undefined' && typeof element.props === 'object'); |
There was a problem hiding this comment.
- we can add small function
isObject, to make code more readable element.hasOwnProperty('type')
what do you think about that?
There was a problem hiding this comment.
- isObject equal typeof object == 'object'?
- That's good.
There was a problem hiding this comment.
i write it now
return object !== null && typeof object === 'object' && !Array.isArray(object);
sigorilla
requested changes
Feb 14, 2017
src/index.js
Outdated
|
|
||
| /** | ||
| * @param {RenderElement} element | ||
| * @returns {boolean} isValid |
There was a problem hiding this comment.
I think it should be Boolean (in Title case)
There was a problem hiding this comment.
Ok. I think about it like a primitive, but it's a Boolean so that's right.
…replace type check with isObject in isValiElement, replace not undefined check with hasOwnProperty type in isValidElement
|
Fix change requests. Please review ._. |
sigorilla
approved these changes
Feb 14, 2017
|
thanks for contribution 🎉 |
|
Thanks for release 🙆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21 implement isValidElement