From 6238bdc1e6d89d5f5324791e50bfa6bbe6a116d7 Mon Sep 17 00:00:00 2001 From: Samuel Imolorhe Date: Sun, 15 Dec 2019 12:53:23 +0100 Subject: [PATCH] Fixed getAltairHtml bug with resolving path. --- packages/altair-static/src/index.ts | 5 +---- packages/altair-static/src/utils/get-altair-html.ts | 3 ++- packages/altair-static/src/utils/get-dist.ts | 6 ++++++ 3 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 packages/altair-static/src/utils/get-dist.ts diff --git a/packages/altair-static/src/index.ts b/packages/altair-static/src/index.ts index 71f072fa72..7883dc7697 100644 --- a/packages/altair-static/src/index.ts +++ b/packages/altair-static/src/index.ts @@ -115,9 +115,6 @@ function getObjectPropertyForOption(option: any, propertyName: string) { return ''; } -/** - * Returns the path to Altair assets, for resolving the assets when rendering Altair - */ -export const getDistDirectory = () => resolve(__dirname, 'dist'); +export { getDistDirectory } from './utils/get-dist'; export default renderAltair; diff --git a/packages/altair-static/src/utils/get-altair-html.ts b/packages/altair-static/src/utils/get-altair-html.ts index 6d4d84477a..4887552086 100644 --- a/packages/altair-static/src/utils/get-altair-html.ts +++ b/packages/altair-static/src/utils/get-altair-html.ts @@ -1,6 +1,7 @@ import { readFileSync } from 'fs'; import { resolve } from 'path'; +import { getDistDirectory } from './get-dist'; export default function getAltairHtml() { - return readFileSync(resolve(__dirname, 'dist/index.html'), 'utf8'); + return readFileSync(resolve(getDistDirectory(), 'index.html'), 'utf8'); } diff --git a/packages/altair-static/src/utils/get-dist.ts b/packages/altair-static/src/utils/get-dist.ts new file mode 100644 index 0000000000..c27b3c8c70 --- /dev/null +++ b/packages/altair-static/src/utils/get-dist.ts @@ -0,0 +1,6 @@ +import { resolve } from 'path'; + +/** + * Returns the path to Altair assets, for resolving the assets when rendering Altair + */ +export const getDistDirectory = () => resolve(__dirname, '../dist');