MAINT: get working with latest versions of Altair and ipywidgets #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stsievert
force-pushed
the
update-versions
branch
from
3239a4e
to
cb44009
Compare
|
This PR is ready for merge – it's not perfect, but can be improved. Here's a screenshot of the widget:
The issues with this:
I'll leave these issues to be resolved later and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #11 and #12.
This PR chooses renders the Altair chart as SVG each time the plot is updated:
This is with Altair 2.2.2 and ipywidgets 7.2.1.
The update takes about 2.5 seconds anytime a button is clicked, which is really annoying. I don't think I'll resolve that in this PR.
TODO: