Permalink
Switch branches/tags
Commits on Jan 2, 2012
  1. Fixing whitespace

    altenmueller committed Dec 27, 2011
  2. Fixing whitespace

    altenmueller committed Dec 27, 2011
  3. Fixed playlist mode bug

    altenmueller committed Dec 27, 2011
  4. Updated summary of changes

    altenmueller committed Dec 25, 2011
Commits on Oct 25, 2011
  1. Merge pull request #14 from thp/master

    ryanflannery committed Oct 25, 2011
    Fix builds for Linux by adding missing object files.
    Fixes #11
Commits on Oct 22, 2011
  1. Makefile.linux: Fix builds on Linux

    thp committed Oct 22, 2011
    Add mplayer.o, socket.o and player_utils.o to
    the list of required object files and add VPATH.
Commits on Oct 18, 2011
  1. Merge pull request #13 from edma2/playlistfix

    ryanflannery committed Oct 18, 2011
    Ignore nonzero return value of glob if it returns GLOB_NOMATCH.
Commits on Oct 16, 2011
  1. Ignore nonzero return value of glob if it returns GLOB_NOMATCH.

    edma2 committed Oct 16, 2011
    This will fix issue #12 which unnecessarily kills vitunes
Commits on Feb 25, 2011
  1. Remove unused parameter to process_signals.

    ryanflannery committed Feb 25, 2011
    Need to find a better way of handling warning/error/fatal messages,
    in general.  Thinking of creating another, small API for it.
  2. Check if mplayer is in $PATH before starting it.

    ryanflannery committed Feb 25, 2011
    This should provide an easier to understand error message for users.
  3. Allow changing the player backend with -m.

    ryanflannery committed Feb 25, 2011
    This hijacks the use of -m, but I don't think this will be a problem
    as the current 'supported' list of ports is taken care of with
    mplayer in the $PATH.
    
    config.h now contains the default backend string.
    
    Updated the man page to reflect this change, and added a note that
    for the mplayer backend, mplayer must be in $PATH.
  4. Made player callbacks variable argument.

    ryanflannery committed Feb 25, 2011
    This makes getting more informative messages from the backends
    easier.
    
    For now, the notice/error callbacks are just set to paint_message
    and paint_error, respectively.
  5. Restarting mplayer now works as before.

    ryanflannery committed Feb 25, 2011
    Better error messages are in order, but for now, she'll do.
  6. Fixed (mostly) a dead mplayer. It now auto-restarts, as before.

    ryanflannery committed Feb 25, 2011
    A few new callbacks to the setup for notices/fatal-errors, but the
    fatal error callback currently doesn't exit.
    
    Also, this doesn't catch a missing mplayer.  Not sure why.  Will
    dig into later.
  7. Removing vitunes dependency from mplayer.

    ryanflannery committed Feb 25, 2011
    Left a #include in there.
  8. Backend suport established for mplayer.

    ryanflannery committed Feb 25, 2011
    This establishes what, I hope, is a good setup for supporting multiple
    players.  Currently only mplayer is supported with this, but the setup
    allows for:
       1. "Static" backends, like mplayer, that have no build dependencies
       2. Dynamically loaded backends, should we desire.
    
    Well, #2 isn't supported, but I believe the setup can be easily
    updated.
    
    The player logic has been heavily modified.  See player.h for details,
    and how the player_info and player struct's are used in paint.h for a
    good overview of the new setup.
    
    --HG--
    rename : players/player.c => player.c
    rename : players/player.h => player.h
    rename : players/player.c => players/mplayer.c
    rename : players/player.h => players/mplayer.h
  9. Forgotten commits for previous commit.

    ryanflannery committed Feb 25, 2011
    Still getting used to git...
  10. Getting base ready for multiple-player support.

    ryanflannery committed Feb 25, 2011
    Created a players/ subdirectory and moved the existing, mplayer-
    specific player.* files into it.
    
    Builds & works with BSD-make no problem.  GNU-make doesn't seem to
    understand .PATH.
  11. Removed hard-coding of mplayer path. Rely on $PATH

    ryanflannery committed Feb 25, 2011
    Since the OS X port now seems to work fine with an mplayer path of
       /usr/local/bin
    And not the previous
       /Application/OMG/some/huge/hideous.app/path/bin/mplayer
    I'm switching back to execvp(2) for launching mplayer.
    
    Fun fact I never knew: You can still provide a full-path to execvp(2)
    and it will work just fine.  D'oh!
  12. Set close-on-exit on socket.

    knk committed Feb 24, 2011
    This makes sure the socket fd doesn't leak to child processes
    (e.g. mplayer) and prevent reopening of it.
  13. Some minor changes to accomodate newer clang/scan-build versions,

    ryanflannery committed Feb 25, 2011
    where it complained about using KbaArgs with unitialized values.
    
    NOTE: All keybinding handler functions (kba_*) should error *hard*
    if any of the parameters they use are incorrect.  That is, they
    shouldn't do:
        if (a.direction == UP)
          ...
        else
          ...
    
    Instead, they should do:
       switch (a.direction) {
       case UP:
          ...
          break;
       case DOWN:
          ...
          break;
       default:
          errx(1, "%s: invalid direction", __FUNCTION__);
       }
Commits on Feb 24, 2011
  1. Remove display of volume from the paint_player function. Now, when

    ryanflannery committed Feb 24, 2011
    the volume changes, a message is painted in the status bar.