Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color fix needed? #220

Open
hemanth opened this Issue Sep 12, 2012 · 133 comments

Comments

Projects
None yet
@hemanth
Copy link

hemanth commented Sep 12, 2012

color

That's how it looks in my terminal, can read the text only after highlighting them!

The color of the text is gray!

@sindresorhus

This comment has been minimized.

Copy link

sindresorhus commented Sep 12, 2012

This is the grey color that is turned invisible: \x1B[90m

@sindresorhus

This comment has been minimized.

Copy link

sindresorhus commented Oct 8, 2012

@altercation @TrevorBramble bump. A lot of people are experiencing this bug...

@altercation

This comment has been minimized.

Copy link
Owner

altercation commented Oct 8, 2012

What's generating this prompt?

(Yes, this is a significant issue. I want to test and repo)

@sindresorhus

This comment has been minimized.

Copy link

sindresorhus commented Oct 8, 2012

@altercation node-prompt, see here.

Also see the referenced issues above.

That text is invisible because the authors of Solarized Dark made the "bright black" color the same color as the background. Whoops. Also, for some reason, they made almost all of the "bright" colors not lighter, but darker than their "normal" counterparts.

@altercation

This comment has been minimized.

Copy link
Owner

altercation commented Oct 9, 2012

So it's clear, this is not a "whoops" at all, but rather a very intentional and considered compromise based on the shitstorm of conflicting standards, expectations and legacy applications that is terminal emulation.

While a change is possible, and the information about which applications and programs suffer from issues like this is very helpful, it isn't going to happen immediately as any change is going to break the way something works.

This is probably the number one concern I have (the bright black issue) and I will only make a change once I'm certain it's the absolute best option.

@hellais

This comment has been minimized.

Copy link

hellais commented Oct 17, 2012

I was also experiencing this issue with yeoman, not sure on which side the bug should be fixed, but the workaround I found is to use this my Xresources

#define hack_color #1c1c1c
*color8: hack_color

Changing the value of color8 to hack_color (it used to be set to !!base03 #002b36)

@satazor

This comment has been minimized.

Copy link

satazor commented Nov 12, 2012

bump

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 23, 2012

I'm having the issue with the output from an ExpressJS application.

@cobyism

This comment has been minimized.

Copy link

cobyism commented Jan 10, 2013

Just ran into (what I believe is) this issue with yeoman. Here’s what the yeoman usage/help command looks like in iTerm2 with Solarized Dark:

Screen Shot 2013-01-10 at 5 07 30 PM

…and with Solarized Light:

Screen Shot 2013-01-10 at 5 07 09 PM

@cobyism

This comment has been minimized.

Copy link

cobyism commented Jan 10, 2013

Another example is the usage command of bower.

Screen Shot 2013-01-10 at 5 22 44 PM
Screen Shot 2013-01-10 at 5 23 13 PM

@mleveck

This comment has been minimized.

Copy link

mleveck commented Jan 22, 2013

What is the status of this? I just installed Yeoman 0.9.6 and large chunks of text are invisible in iTerm 2 with solarized dark. I'd let it go but:

  1. My setup is far from uncommon. I'd say most OS X devs I know use iTerm2 and Solarized.
  2. By definition Yeoman is a tool to make life easier, so I'd hope that fixing things like this might be a bit of a priority.
@ghost

This comment has been minimized.

Copy link

ghost commented Jan 22, 2013

@mleveck You can look into the version in my pull request. Yeoman looks better with it...

Screen Shot 2013-01-21 at 7 59 14 PM

@necolas

This comment has been minimized.

Copy link

necolas commented Apr 29, 2013

Related problem in Mocha too - mochajs/mocha#802

@sindresorhus

This comment has been minimized.

Copy link

sindresorhus commented Apr 29, 2013

:/

@ghost

This comment has been minimized.

Copy link

ghost commented Apr 29, 2013

Other themes give me the same problems such as Tomorrow Night Bright at https://github.com/chriskempson/tomorrow-theme. Really annoying.

@paulirish

This comment has been minimized.

Copy link

paulirish commented Apr 30, 2013

@altercation can you please look into this.
Seems bad to advocate that people to abandon solarized but... 6 months in, we're just about at that point.

@altercation

This comment has been minimized.

Copy link
Owner

altercation commented Apr 30, 2013

@paulirish Sure. I'll take a look.

@necolas

This comment has been minimized.

Copy link

necolas commented Jul 25, 2013

This problem is also affecting Express: expressjs/express#1700

Most of the popular front-end tools have been or are affected by this long-standing bug.

@sindresorhus

This comment has been minimized.

Copy link

sindresorhus commented Jul 25, 2013

This is just ridiculous...

@metakermit

This comment has been minimized.

Copy link

metakermit commented Mar 2, 2016

If someone is still having trouble with this issue and since hydrozen's fork mentioned that fixes this is no longer available (the user is shown as @ghost now and the old https://github.com/hydrozen/solarized repo is gone), you might want to try the Solarized Dark Patched theme available in https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this file, enter your iTerm preferences -> Profiles -> Colors -> Load Presets... -> Import... and select & activate the theme. That's how I managed to solve the issue for myself.

@dfournier

This comment has been minimized.

Copy link

dfournier commented Mar 3, 2016

I moved to https://github.com/chriskempson/base16 with solorized theme.
Works perfectly!

On Wed, Mar 2, 2016 at 10:39 PM Dražen Lučanin notifications@github.com
wrote:

If someone is still having trouble with this issue and since hydrozen's
fork mentioned that fixes this is no longer available (the user is shown as
@ghost https://github.com/ghost now and the old
https://github.com/hydrozen/solarized repo is gone), you might want to
try the Solarized Dark Patched theme available in
https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this
file
https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/Solarized%20Dark%20-%20Patched.itermcolors,
enter your iTerm preferences -> Profiles -> Colors -> Load Presets... ->
Import... and select & activate the theme. That's how I managed to solve
the issue for myself.


Reply to this email directly or view it on GitHub
#220 (comment)
.

@zeorin

This comment has been minimized.

Copy link

zeorin commented Apr 23, 2016

+1 for fixing this issue if possible. @cuviper's solution of switching which ANSI codes base02 base03 are mapped to seems the most reasonable.

I think Solarized works so well because of the careful colour choices, so any solution that changes the colours would not be the best, IMO. Switching the ANSI mappings would mean that any theme/colourscheme in a cli program that counts on the Solarized theme to be the terminal colours would have to be adjusted, sure.

But compared to the alternatives (choose a new colour that doesn't fit the thinking, change to a different colour scheme, change the whole contrast of the scheme, or just lose users over time) it's reasonable: it's a small change for "downstream" themes, and at least brblack will be visible.

Sure, one can argue that others shouldn't be putting important information in brblack, but it should at least be visible.

It's a non-backwards compatible-change, sure. These things happen in software projects. Let's handle it.

@icyflame

This comment has been minimized.

Copy link

icyflame commented May 6, 2016

@hemanth Can you please change the name of this issue? (Clearly, the fix is required. That would help in avoiding opening of new issues. I searched for the issue that I was facing and ended up opening #351 , until @zeorin informed me that the issue has already been reported.) Thanks!

And yeah, +1 for fixing this issue.

@anarcat

This comment has been minimized.

Copy link

anarcat commented Jun 2, 2016

for the record, i have mostly alleviated the problems here by switching from xterm to rxvt-unicode...

@zeorin

This comment has been minimized.

Copy link

zeorin commented Aug 23, 2016

Hi all,

I don’t think that, outside of forking this project ourselves, this issue or any other issues are likely to be fixed.

So that’s exactly what I’m proposing: let’s create a community-maintained fork!

I’ve created a new issue for the discussion of this idea: #355

Please do chime in.

@goyatparmod

This comment has been minimized.

Copy link

goyatparmod commented Aug 26, 2016

image

Left hand side is OSX terminal app and left hand side is iterm2. Font size and color scheme is same..
But color and font rendering is different. Any idea how i can fix OSX terminal color rendering.
Red,Cyan and Magenta color are different in OSX terminal.

@sheeit

This comment has been minimized.

Copy link

sheeit commented Nov 11, 2016

Here's a simple command to reproduce this:
if you have your terminal set up with the Solarized theme, just do

printf 'Normal text. \033[1;30mInvisible text\033[0m.\n'

The text "Invisible text" will not be visible.

solarized

@ivanmanolov90

This comment has been minimized.

Copy link

ivanmanolov90 commented Jan 2, 2017

i hope there are plans to fix this. I noticed the problem when trying to use mocha for the first time after changing to the solarized theme in iTerm2. Here is my work around for the moment:

s0meone added a commit to s0meone/eslint-watch that referenced this issue Jun 14, 2017

rizowski added a commit to rizowski/eslint-watch that referenced this issue Jun 14, 2017

jdxcode pushed a commit to heroku/cli-engine-command that referenced this issue Jul 1, 2017

Jeff Dickey
@tyrsius

This comment has been minimized.

Copy link

tyrsius commented Jul 13, 2017

@altercation Its been 4 years since you said you would take a look. Has there been any progress on this, or should we abandon solarized dark?

@icyflame

This comment has been minimized.

Copy link

icyflame commented Jul 14, 2017

hey @tyrsius, the possibility of this being fixed is remote. You should try using base16, I switched to that when I first encountered this issue and it's been pretty good. 😄

jdxcode added a commit to heroku/cli-engine-command that referenced this issue Aug 28, 2017

@lee-dohm lee-dohm referenced this issue Feb 1, 2018

Closed

Probot feedback from GitHub Ecosystem Hackathon #22

3 of 6 tasks complete
@jacoscaz

This comment has been minimized.

Copy link

jacoscaz commented Oct 26, 2018

@ivanmanolov90's solutions seems to works perfectly for me - at least with the tools I use.

@bobf

This comment has been minimized.

Copy link

bobf commented Oct 28, 2018

I "fixed" this by setting iTerm2's black light colour to 0387ad (as suggested by @ivanmanolov90 ) and then using the following settings:

set background=dark
let g:solarized_termtrans = 1
colorscheme solarized

I know this won't work for everyone but if your setup is like mine then maybe it'll save you 15 minutes of frustration.

@icyflame

This comment has been minimized.

Copy link

icyflame commented Oct 28, 2018

I copied over the colors from gnome-terminal to iTerm2 and created a new color scheme. here. I tried using both base16 and base256 for iTerm2, but the first one simply didn't show some text and the second one had a weird problem where the difference between folders and files was very small (they were both white and the difference in font weight was not noticeable at all)

I have been using this for a couple days now, and it's not shown up any problems. I will report here if it does.

P.S the copying over process was pretty simple and you should absolutely do it if you have a preferred setup on a computer that works fine and want to emulate the setup elsewhere. (Not sure if this was already discussed here, I was unable to find it anywhere) 🤔

@laggardkernel

This comment has been minimized.

Copy link

laggardkernel commented Mar 5, 2019

I copied over the colors from gnome-terminal to iTerm2 and created a new color scheme. here.

I see. You're using the normal colors as the bright ones. I'm going to do the same. At least, the bright colors are not grey anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.