Color fix needed? #220

Open
hemanth opened this Issue Sep 12, 2012 · 129 comments

Comments

Projects
None yet
@hemanth

hemanth commented Sep 12, 2012

color

That's how it looks in my terminal, can read the text only after highlighting them!

The color of the text is gray!

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Sep 12, 2012

This is the grey color that is turned invisible: \x1B[90m

This is the grey color that is turned invisible: \x1B[90m

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Oct 8, 2012

@altercation @TrevorBramble bump. A lot of people are experiencing this bug...

@altercation @TrevorBramble bump. A lot of people are experiencing this bug...

@altercation

This comment has been minimized.

Show comment
Hide comment
@altercation

altercation Oct 8, 2012

Owner

What's generating this prompt?

(Yes, this is a significant issue. I want to test and repo)

Owner

altercation commented Oct 8, 2012

What's generating this prompt?

(Yes, this is a significant issue. I want to test and repo)

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Oct 8, 2012

@altercation node-prompt, see here.

Also see the referenced issues above.

That text is invisible because the authors of Solarized Dark made the "bright black" color the same color as the background. Whoops. Also, for some reason, they made almost all of the "bright" colors not lighter, but darker than their "normal" counterparts.

@altercation node-prompt, see here.

Also see the referenced issues above.

That text is invisible because the authors of Solarized Dark made the "bright black" color the same color as the background. Whoops. Also, for some reason, they made almost all of the "bright" colors not lighter, but darker than their "normal" counterparts.

@altercation

This comment has been minimized.

Show comment
Hide comment
@altercation

altercation Oct 9, 2012

Owner

So it's clear, this is not a "whoops" at all, but rather a very intentional and considered compromise based on the shitstorm of conflicting standards, expectations and legacy applications that is terminal emulation.

While a change is possible, and the information about which applications and programs suffer from issues like this is very helpful, it isn't going to happen immediately as any change is going to break the way something works.

This is probably the number one concern I have (the bright black issue) and I will only make a change once I'm certain it's the absolute best option.

Owner

altercation commented Oct 9, 2012

So it's clear, this is not a "whoops" at all, but rather a very intentional and considered compromise based on the shitstorm of conflicting standards, expectations and legacy applications that is terminal emulation.

While a change is possible, and the information about which applications and programs suffer from issues like this is very helpful, it isn't going to happen immediately as any change is going to break the way something works.

This is probably the number one concern I have (the bright black issue) and I will only make a change once I'm certain it's the absolute best option.

@hellais

This comment has been minimized.

Show comment
Hide comment
@hellais

hellais Oct 17, 2012

I was also experiencing this issue with yeoman, not sure on which side the bug should be fixed, but the workaround I found is to use this my Xresources

#define hack_color #1c1c1c
*color8: hack_color

Changing the value of color8 to hack_color (it used to be set to !!base03 #002b36)

hellais commented Oct 17, 2012

I was also experiencing this issue with yeoman, not sure on which side the bug should be fixed, but the workaround I found is to use this my Xresources

#define hack_color #1c1c1c
*color8: hack_color

Changing the value of color8 to hack_color (it used to be set to !!base03 #002b36)

@satazor

This comment has been minimized.

Show comment
Hide comment

satazor commented Nov 12, 2012

bump

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 23, 2012

I'm having the issue with the output from an ExpressJS application.

ghost commented Nov 23, 2012

I'm having the issue with the output from an ExpressJS application.

@cobyism

This comment has been minimized.

Show comment
Hide comment
@cobyism

cobyism Jan 10, 2013

Just ran into (what I believe is) this issue with yeoman. Here’s what the yeoman usage/help command looks like in iTerm2 with Solarized Dark:

Screen Shot 2013-01-10 at 5 07 30 PM

…and with Solarized Light:

Screen Shot 2013-01-10 at 5 07 09 PM

cobyism commented Jan 10, 2013

Just ran into (what I believe is) this issue with yeoman. Here’s what the yeoman usage/help command looks like in iTerm2 with Solarized Dark:

Screen Shot 2013-01-10 at 5 07 30 PM

…and with Solarized Light:

Screen Shot 2013-01-10 at 5 07 09 PM

@cobyism

This comment has been minimized.

Show comment
Hide comment
@cobyism

cobyism Jan 10, 2013

Another example is the usage command of bower.

Screen Shot 2013-01-10 at 5 22 44 PM
Screen Shot 2013-01-10 at 5 23 13 PM

cobyism commented Jan 10, 2013

Another example is the usage command of bower.

Screen Shot 2013-01-10 at 5 22 44 PM
Screen Shot 2013-01-10 at 5 23 13 PM

@mleveck

This comment has been minimized.

Show comment
Hide comment
@mleveck

mleveck Jan 22, 2013

What is the status of this? I just installed Yeoman 0.9.6 and large chunks of text are invisible in iTerm 2 with solarized dark. I'd let it go but:

  1. My setup is far from uncommon. I'd say most OS X devs I know use iTerm2 and Solarized.
  2. By definition Yeoman is a tool to make life easier, so I'd hope that fixing things like this might be a bit of a priority.

mleveck commented Jan 22, 2013

What is the status of this? I just installed Yeoman 0.9.6 and large chunks of text are invisible in iTerm 2 with solarized dark. I'd let it go but:

  1. My setup is far from uncommon. I'd say most OS X devs I know use iTerm2 and Solarized.
  2. By definition Yeoman is a tool to make life easier, so I'd hope that fixing things like this might be a bit of a priority.
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 22, 2013

@mleveck You can look into the version in my pull request. Yeoman looks better with it...

Screen Shot 2013-01-21 at 7 59 14 PM

ghost commented Jan 22, 2013

@mleveck You can look into the version in my pull request. Yeoman looks better with it...

Screen Shot 2013-01-21 at 7 59 14 PM

@necolas

This comment has been minimized.

Show comment
Hide comment
@necolas

necolas Apr 29, 2013

Related problem in Mocha too - mochajs/mocha#802

necolas commented Apr 29, 2013

Related problem in Mocha too - mochajs/mocha#802

@sindresorhus

This comment has been minimized.

Show comment
Hide comment

:/

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 29, 2013

Other themes give me the same problems such as Tomorrow Night Bright at https://github.com/chriskempson/tomorrow-theme. Really annoying.

ghost commented Apr 29, 2013

Other themes give me the same problems such as Tomorrow Night Bright at https://github.com/chriskempson/tomorrow-theme. Really annoying.

@paulirish

This comment has been minimized.

Show comment
Hide comment
@paulirish

paulirish Apr 30, 2013

@altercation can you please look into this.
Seems bad to advocate that people to abandon solarized but... 6 months in, we're just about at that point.

@altercation can you please look into this.
Seems bad to advocate that people to abandon solarized but... 6 months in, we're just about at that point.

@altercation

This comment has been minimized.

Show comment
Hide comment
@altercation

altercation Apr 30, 2013

Owner

@paulirish Sure. I'll take a look.

Owner

altercation commented Apr 30, 2013

@paulirish Sure. I'll take a look.

@sindresorhus sindresorhus referenced this issue in sindresorhus/pure Jul 11, 2013

Closed

Color for branch #5

@necolas

This comment has been minimized.

Show comment
Hide comment
@necolas

necolas Jul 25, 2013

This problem is also affecting Express: expressjs/express#1700

Most of the popular front-end tools have been or are affected by this long-standing bug.

necolas commented Jul 25, 2013

This problem is also affecting Express: expressjs/express#1700

Most of the popular front-end tools have been or are affected by this long-standing bug.

@necolas necolas referenced this issue in expressjs/express Jul 25, 2013

Closed

Color problems in terminal with certain themes #1700

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jul 25, 2013

This is just ridiculous...

This is just ridiculous...

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 25, 2013

I know it’s not ideal, and nor maybe the correct solution, but some people have been getting good results from my fork at https://github.com/hydrozen/solarized. I tweaked the iTerm2 theme and the vim theme and it seems to work well enough for me.

ghost commented Jul 25, 2013

I know it’s not ideal, and nor maybe the correct solution, but some people have been getting good results from my fork at https://github.com/hydrozen/solarized. I tweaked the iTerm2 theme and the vim theme and it seems to work well enough for me.

@henrahmagix

This comment has been minimized.

Show comment
Hide comment
@henrahmagix

henrahmagix Jul 26, 2013

+1 for @hydrozen's fork. I'm using it successfully, but only with iTerm2.

+1 for @hydrozen's fork. I'm using it successfully, but only with iTerm2.

@brianarn

This comment has been minimized.

Show comment
Hide comment
@brianarn

brianarn Jul 29, 2013

Another +1 for @hydrozen's fork and iTerm 2 usage. Works quite well, just set it up now. 👍

Another +1 for @hydrozen's fork and iTerm 2 usage. Works quite well, just set it up now. 👍

@mbrevda

This comment has been minimized.

Show comment
Hide comment
@mbrevda

mbrevda Sep 8, 2013

As per #164, this is easly fixed by uping the contrast in iterm2 (I found a about a third from the left to be optimal)

mbrevda commented Sep 8, 2013

As per #164, this is easly fixed by uping the contrast in iterm2 (I found a about a third from the left to be optimal)

@benhoskings

This comment has been minimized.

Show comment
Hide comment
@benhoskings

benhoskings Sep 25, 2013

The issue is that there is no way to render a low-intensity, neutral colour on Solarized in a way that also works with default terminal colour schemes. Here are the some schemes for comparison:

#!/usr/bin/env ruby

puts "running in an #{ENV['TERM']} (#{ENV['TERM_PROGRAM']})"

[2, 30, 37, 90, 97].each {|code|
  puts "using \\e[#{code}m: \e[#{code}mbam\e[0m"
}

A textmode linux pty: linux pty

A basic xterm's default scheme: xterm

OS X Terminal.app's default scheme: Terminal.app

Solarized light: Solarized light

Solarized dark: Solarized dark

                       linux pty   xterm     Terminal.app   solarized light  solarized dark
"\e[2m" low int.       -           -         low int.       -                -
"\e[30m" black         invisible   -         -              grey (*)         v faint
"\e[37m" white         -           white     white          white            white
"\e[90m" bright black  -           grey (*)  grey (*)       grey (*)         invisible

Notes:

  • The '-' above means unchanged, i.e. the standard foreground colour for that scheme.
  • 'low int' is an ANSI code which renders the given colour at a lower intensity. It would be useful for our purposes, but it's not widely supported.
  • 'white' isn't always quite the same as the background white, but it's close enough that text rendered in white isn't readable.

As you can see, you get grey by using "bright black", because that's what the standard colour schemes support. (These are the terminals I have at hand, but I've seen this borne out over others too.) Solarized aside, everything correctly renders ansi 90m as grey, except a linux pty, which doesn't change colour.

(The only way to get grey on a linux pty is to render bold black text on a black background, 1;30;40m. This changes the background colour on a non-black terminal and results in invisible text in most xterm-like emulators. Can't win 'em all!)

Solarized dark's "bright black", though, is the same as the background colour. I'd be interested to hear the reasoning behind this choice, but in the meantime, in my opinion it's incorrect and ripe for fixing. Raising Solarized dark's 'bright black' slightly would do the trick.

I use a tweaked solarized and have bright black set to R30,G100,B118 which looks good to my eyes: Solarized ben_h

The issue is that there is no way to render a low-intensity, neutral colour on Solarized in a way that also works with default terminal colour schemes. Here are the some schemes for comparison:

#!/usr/bin/env ruby

puts "running in an #{ENV['TERM']} (#{ENV['TERM_PROGRAM']})"

[2, 30, 37, 90, 97].each {|code|
  puts "using \\e[#{code}m: \e[#{code}mbam\e[0m"
}

A textmode linux pty: linux pty

A basic xterm's default scheme: xterm

OS X Terminal.app's default scheme: Terminal.app

Solarized light: Solarized light

Solarized dark: Solarized dark

                       linux pty   xterm     Terminal.app   solarized light  solarized dark
"\e[2m" low int.       -           -         low int.       -                -
"\e[30m" black         invisible   -         -              grey (*)         v faint
"\e[37m" white         -           white     white          white            white
"\e[90m" bright black  -           grey (*)  grey (*)       grey (*)         invisible

Notes:

  • The '-' above means unchanged, i.e. the standard foreground colour for that scheme.
  • 'low int' is an ANSI code which renders the given colour at a lower intensity. It would be useful for our purposes, but it's not widely supported.
  • 'white' isn't always quite the same as the background white, but it's close enough that text rendered in white isn't readable.

As you can see, you get grey by using "bright black", because that's what the standard colour schemes support. (These are the terminals I have at hand, but I've seen this borne out over others too.) Solarized aside, everything correctly renders ansi 90m as grey, except a linux pty, which doesn't change colour.

(The only way to get grey on a linux pty is to render bold black text on a black background, 1;30;40m. This changes the background colour on a non-black terminal and results in invisible text in most xterm-like emulators. Can't win 'em all!)

Solarized dark's "bright black", though, is the same as the background colour. I'd be interested to hear the reasoning behind this choice, but in the meantime, in my opinion it's incorrect and ripe for fixing. Raising Solarized dark's 'bright black' slightly would do the trick.

I use a tweaked solarized and have bright black set to R30,G100,B118 which looks good to my eyes: Solarized ben_h

@benhoskings

This comment has been minimized.

Show comment
Hide comment
@benhoskings

benhoskings Sep 29, 2013

Oops, I made a little mistake above :) There's no need to render a background behind "bold black" text on a linux PTY, hence the 1;30;40m that I quoted can be simplified to 1;30m.

Without the black background, the text is visible on all terminals, but it doesn't render consistently enough to be useable for grey. A linux pty will render it in grey, but most standard themes will render it as bold, black text. (Solarized dark renders it in a very dark grey, too dark to be easily read.)

(I think "bright black" \e[90m is the right choice for grey regardless of this.)

Oops, I made a little mistake above :) There's no need to render a background behind "bold black" text on a linux PTY, hence the 1;30;40m that I quoted can be simplified to 1;30m.

Without the black background, the text is visible on all terminals, but it doesn't render consistently enough to be useable for grey. A linux pty will render it in grey, but most standard themes will render it as bold, black text. (Solarized dark renders it in a very dark grey, too dark to be easily read.)

(I think "bright black" \e[90m is the right choice for grey regardless of this.)

@fedemp fedemp referenced this issue in jonathanfilip/lucius Sep 30, 2013

Open

Normal and bright should not be equal #2

@mattcreager mattcreager referenced this issue in mattcreager/generator-column Nov 8, 2013

Closed

Diffs in terminal impossible to read #10

@imjared imjared referenced this issue in yeoman/generator Nov 8, 2013

Closed

Diffs in terminal impossible to read #397

@zevaverbach

This comment has been minimized.

Show comment
Hide comment
@zevaverbach

zevaverbach Jan 1, 2016

@nicolasmccurdy thanks for the tip. just spent 30 mins trying to get that to work. (similarly awful salmonesque results in vim)

screen shot 2016-01-01 at 4 51 30 am

@nicolasmccurdy thanks for the tip. just spent 30 mins trying to get that to work. (similarly awful salmonesque results in vim)

screen shot 2016-01-01 at 4 51 30 am

@nickmccurdy

This comment has been minimized.

Show comment
Hide comment
@nickmccurdy

nickmccurdy Jan 1, 2016

Huh, so does their solarized theme seem to be a good alternative in general?

Huh, so does their solarized theme seem to be a good alternative in general?

@zevaverbach

This comment has been minimized.

Show comment
Hide comment
@zevaverbach

zevaverbach Jan 1, 2016

I can't get base16 to work in my terminal in the first place, so I can't say. Looks great on the site!

I can't get base16 to work in my terminal in the first place, so I can't say. Looks great on the site!

@anarcat

This comment has been minimized.

Show comment
Hide comment
@anarcat

anarcat Jan 1, 2016

i have come to see this problem as un-solvable: the solarized color scheme is a hack, and it changes colors fundamentally in a way that breaks applications that expect certain colors to have certain contrast, by using weird background colors (e.g. iptraf). most of the time, i can switch color schemes in those to be simpler (e.g. B&W in iptraf), so i have mostly given up on this issue.

anarcat commented Jan 1, 2016

i have come to see this problem as un-solvable: the solarized color scheme is a hack, and it changes colors fundamentally in a way that breaks applications that expect certain colors to have certain contrast, by using weird background colors (e.g. iptraf). most of the time, i can switch color schemes in those to be simpler (e.g. B&W in iptraf), so i have mostly given up on this issue.

leighman added a commit to leighman/eslint that referenced this issue Jan 8, 2016

Fix output on Solarized Dark terminal theme
There is a long-standing solarized bug [1] where gray text is invisible
on the dark theme.
Follow Chalk's advice [2] and use 'dim' rather than 'gray'.

[1] altercation/solarized#220
[2] chalk/chalk#40

leighman added a commit to leighman/eslint that referenced this issue Jan 8, 2016

Fix: gray text was invisible on Solarized Dark theme
There is a long-standing solarized bug [1] where gray text is invisible
on the dark theme.
Follow Chalk's advice [2] and use 'dim' rather than 'gray'.

[1] altercation/solarized#220
[2] chalk/chalk#40

leighman added a commit to leighman/eslint that referenced this issue Jan 8, 2016

Fix: gray text was invisible on Solarized Dark theme (fixes #4886)
There is a long-standing solarized bug [1] where gray text is invisible
on the dark theme.
Follow Chalk's advice [2] and use 'dim' rather than 'gray'.

[1] altercation/solarized#220
[2] chalk/chalk#40

@jez jez referenced this issue in mbadolato/iTerm2-Color-Schemes Jan 12, 2016

Closed

The Solarized Dark change should be reverted #62

@leighman leighman referenced this issue in natefaubion/purescript-psa Jan 12, 2016

Closed

Please consider using 'dim' mode instead of 'Grey' colour #6

@jez jez referenced this issue in mbadolato/iTerm2-Color-Schemes Jan 21, 2016

Merged

Re-add theme as Solarized Dark - Patched #63

@ArcadeFever

This comment has been minimized.

Show comment
Hide comment
@ArcadeFever

ArcadeFever Jan 26, 2016

+1 for adjusting contrast in iterm2 to solve this

+1 for adjusting contrast in iterm2 to solve this

@pgarrison

This comment has been minimized.

Show comment
Hide comment
@pgarrison

pgarrison Feb 25, 2016

@dfournier You can still see the changes at #240.

I solved this (at least among the tools I use) on urxvt by mapping color8 to base01 in my Xresources and tweaking the vim theme (pgarrison/vim-colors-solarized).

@dfournier You can still see the changes at #240.

I solved this (at least among the tools I use) on urxvt by mapping color8 to base01 in my Xresources and tweaking the vim theme (pgarrison/vim-colors-solarized).

@metakermit

This comment has been minimized.

Show comment
Hide comment
@metakermit

metakermit Mar 2, 2016

If someone is still having trouble with this issue and since hydrozen's fork mentioned that fixes this is no longer available (the user is shown as @ghost now and the old https://github.com/hydrozen/solarized repo is gone), you might want to try the Solarized Dark Patched theme available in https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this file, enter your iTerm preferences -> Profiles -> Colors -> Load Presets... -> Import... and select & activate the theme. That's how I managed to solve the issue for myself.

If someone is still having trouble with this issue and since hydrozen's fork mentioned that fixes this is no longer available (the user is shown as @ghost now and the old https://github.com/hydrozen/solarized repo is gone), you might want to try the Solarized Dark Patched theme available in https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this file, enter your iTerm preferences -> Profiles -> Colors -> Load Presets... -> Import... and select & activate the theme. That's how I managed to solve the issue for myself.

@dfournier

This comment has been minimized.

Show comment
Hide comment
@dfournier

dfournier Mar 3, 2016

I moved to https://github.com/chriskempson/base16 with solorized theme.
Works perfectly!

On Wed, Mar 2, 2016 at 10:39 PM Dražen Lučanin notifications@github.com
wrote:

If someone is still having trouble with this issue and since hydrozen's
fork mentioned that fixes this is no longer available (the user is shown as
@ghost https://github.com/ghost now and the old
https://github.com/hydrozen/solarized repo is gone), you might want to
try the Solarized Dark Patched theme available in
https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this
file
https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/Solarized%20Dark%20-%20Patched.itermcolors,
enter your iTerm preferences -> Profiles -> Colors -> Load Presets... ->
Import... and select & activate the theme. That's how I managed to solve
the issue for myself.


Reply to this email directly or view it on GitHub
#220 (comment)
.

I moved to https://github.com/chriskempson/base16 with solorized theme.
Works perfectly!

On Wed, Mar 2, 2016 at 10:39 PM Dražen Lučanin notifications@github.com
wrote:

If someone is still having trouble with this issue and since hydrozen's
fork mentioned that fixes this is no longer available (the user is shown as
@ghost https://github.com/ghost now and the old
https://github.com/hydrozen/solarized repo is gone), you might want to
try the Solarized Dark Patched theme available in
https://github.com/mbadolato/iTerm2-Color-Schemes . Just download this
file
https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/Solarized%20Dark%20-%20Patched.itermcolors,
enter your iTerm preferences -> Profiles -> Colors -> Load Presets... ->
Import... and select & activate the theme. That's how I managed to solve
the issue for myself.


Reply to this email directly or view it on GitHub
#220 (comment)
.

@zeorin

This comment has been minimized.

Show comment
Hide comment
@zeorin

zeorin Apr 23, 2016

+1 for fixing this issue if possible. @cuviper's solution of switching which ANSI codes base02 base03 are mapped to seems the most reasonable.

I think Solarized works so well because of the careful colour choices, so any solution that changes the colours would not be the best, IMO. Switching the ANSI mappings would mean that any theme/colourscheme in a cli program that counts on the Solarized theme to be the terminal colours would have to be adjusted, sure.

But compared to the alternatives (choose a new colour that doesn't fit the thinking, change to a different colour scheme, change the whole contrast of the scheme, or just lose users over time) it's reasonable: it's a small change for "downstream" themes, and at least brblack will be visible.

Sure, one can argue that others shouldn't be putting important information in brblack, but it should at least be visible.

It's a non-backwards compatible-change, sure. These things happen in software projects. Let's handle it.

zeorin commented Apr 23, 2016

+1 for fixing this issue if possible. @cuviper's solution of switching which ANSI codes base02 base03 are mapped to seems the most reasonable.

I think Solarized works so well because of the careful colour choices, so any solution that changes the colours would not be the best, IMO. Switching the ANSI mappings would mean that any theme/colourscheme in a cli program that counts on the Solarized theme to be the terminal colours would have to be adjusted, sure.

But compared to the alternatives (choose a new colour that doesn't fit the thinking, change to a different colour scheme, change the whole contrast of the scheme, or just lose users over time) it's reasonable: it's a small change for "downstream" themes, and at least brblack will be visible.

Sure, one can argue that others shouldn't be putting important information in brblack, but it should at least be visible.

It's a non-backwards compatible-change, sure. These things happen in software projects. Let's handle it.

@icyflame

This comment has been minimized.

Show comment
Hide comment
@icyflame

icyflame May 6, 2016

@hemanth Can you please change the name of this issue? (Clearly, the fix is required. That would help in avoiding opening of new issues. I searched for the issue that I was facing and ended up opening #351 , until @zeorin informed me that the issue has already been reported.) Thanks!

And yeah, +1 for fixing this issue.

icyflame commented May 6, 2016

@hemanth Can you please change the name of this issue? (Clearly, the fix is required. That would help in avoiding opening of new issues. I searched for the issue that I was facing and ended up opening #351 , until @zeorin informed me that the issue has already been reported.) Thanks!

And yeah, +1 for fixing this issue.

@anarcat

This comment has been minimized.

Show comment
Hide comment
@anarcat

anarcat Jun 2, 2016

for the record, i have mostly alleviated the problems here by switching from xterm to rxvt-unicode...

anarcat commented Jun 2, 2016

for the record, i have mostly alleviated the problems here by switching from xterm to rxvt-unicode...

@zeorin

This comment has been minimized.

Show comment
Hide comment
@zeorin

zeorin Aug 23, 2016

Hi all,

I don’t think that, outside of forking this project ourselves, this issue or any other issues are likely to be fixed.

So that’s exactly what I’m proposing: let’s create a community-maintained fork!

I’ve created a new issue for the discussion of this idea: #355

Please do chime in.

zeorin commented Aug 23, 2016

Hi all,

I don’t think that, outside of forking this project ourselves, this issue or any other issues are likely to be fixed.

So that’s exactly what I’m proposing: let’s create a community-maintained fork!

I’ve created a new issue for the discussion of this idea: #355

Please do chime in.

@goyatparmod

This comment has been minimized.

Show comment
Hide comment
@goyatparmod

goyatparmod Aug 26, 2016

image

Left hand side is OSX terminal app and left hand side is iterm2. Font size and color scheme is same..
But color and font rendering is different. Any idea how i can fix OSX terminal color rendering.
Red,Cyan and Magenta color are different in OSX terminal.

goyatparmod commented Aug 26, 2016

image

Left hand side is OSX terminal app and left hand side is iterm2. Font size and color scheme is same..
But color and font rendering is different. Any idea how i can fix OSX terminal color rendering.
Red,Cyan and Magenta color are different in OSX terminal.

@sheeit

This comment has been minimized.

Show comment
Hide comment
@sheeit

sheeit Nov 11, 2016

Here's a simple command to reproduce this:
if you have your terminal set up with the Solarized theme, just do

echo -e 'Normal text. \033[0;30mInvisible text'

The text "Invisible text" will not be visible.

sheeit commented Nov 11, 2016

Here's a simple command to reproduce this:
if you have your terminal set up with the Solarized theme, just do

echo -e 'Normal text. \033[0;30mInvisible text'

The text "Invisible text" will not be visible.

@ivanmanolov90

This comment has been minimized.

Show comment
Hide comment
@ivanmanolov90

ivanmanolov90 Jan 2, 2017

i hope there are plans to fix this. I noticed the problem when trying to use mocha for the first time after changing to the solarized theme in iTerm2. Here is my work around for the moment:

ivanmanolov90 commented Jan 2, 2017

i hope there are plans to fix this. I noticed the problem when trying to use mocha for the first time after changing to the solarized theme in iTerm2. Here is my work around for the moment:

s0meone added a commit to s0meone/eslint-watch that referenced this issue Jun 14, 2017

@s0meone s0meone referenced this issue in rizowski/eslint-watch Jun 14, 2017

Merged

Make gray text readable on Solarized Dark theme #118

rizowski added a commit to rizowski/eslint-watch that referenced this issue Jun 14, 2017

jdxcode pushed a commit to heroku/cli-engine-command that referenced this issue Jul 1, 2017

Jeff Dickey
@tyrsius

This comment has been minimized.

Show comment
Hide comment
@tyrsius

tyrsius Jul 13, 2017

@altercation Its been 4 years since you said you would take a look. Has there been any progress on this, or should we abandon solarized dark?

tyrsius commented Jul 13, 2017

@altercation Its been 4 years since you said you would take a look. Has there been any progress on this, or should we abandon solarized dark?

@icyflame

This comment has been minimized.

Show comment
Hide comment
@icyflame

icyflame Jul 14, 2017

hey @tyrsius, the possibility of this being fixed is remote. You should try using base16, I switched to that when I first encountered this issue and it's been pretty good. 😄

hey @tyrsius, the possibility of this being fixed is remote. You should try using base16, I switched to that when I first encountered this issue and it's been pretty good. 😄

jdxcode added a commit to heroku/cli-engine-command that referenced this issue Aug 28, 2017

@lee-dohm lee-dohm referenced this issue in probot/friction Feb 1, 2018

Closed

Probot feedback from GitHub Ecosystem Hackathon #22

3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment