Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EasyAdmin filters compatible #153

Open
gisostallenberg opened this issue Aug 1, 2019 · 6 comments

Comments

@gisostallenberg
Copy link

commented Aug 1, 2019

Are there any plans on making EasyAdmin filters compatible instead of just avoid the installation of v2.2.0+ as is done in https://github.com/alterphp/EasyAdminExtensionBundle/releases/tag/v2.1.7?

How can I help?

@alterphp

This comment has been minimized.

Copy link
Owner

commented Aug 1, 2019

Hi @gisostallenberg !

The plan is to use new EasyAdmin filters and remove them from the extension.

But ... embedded lists relies on dynamic list filters. So it requires to migrate embedded list feature to the new filters implementation. For now, list filters from EasyAdmin must be configured, you cannot put a filter in your HTTP request that is not defined in easy_admin config.

What's the plan :

  • Make EasyAdmin filtering totally dynamic, and the configuration of list filters form would only be used to build the form, (ping @javiereguiluz @yceruto WDYT ?),
  • Migrate embedded list to the new filters implementation.

Another main feature that seems being implemented to EasyAdmin : role-based security. This feature will be removed from the extension.

And as I know that embedded list is in a TODO list of EasyAdmin team, I guess this extension will become useless (and that's good!).

To be honest, I have no time this summer to stay tuned on EasyAdmin evolutions and this plan is still "abstract" :-D I think working on EasyAdmin to implement the first item of the plan would help ;-)

@qcho

This comment has been minimized.

Copy link

commented Aug 13, 2019

In the meantime I've sent a PR to make EAEB & EAB filters compatible.

@yceruto

This comment has been minimized.

Copy link

commented Aug 13, 2019

Make EasyAdmin filtering totally dynamic, and the configuration of list filters form would only be used to build the form, (ping @javiereguiluz @yceruto WDYT ?),

Not sure what do you mean with make EasyAdmin filtering totally dynamic... :/

@alterphp

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Hi @yceruto !

When I checked the dynamic filter feature on EAB, only filters configured in the EasyAdmin config were handled by the query builder.
The same HTTP request, with included filters as GET params, but without the list filters configuration should filter the list as well, IMHO.

Is it something you'd expect from EAB list filters ?

@yceruto

This comment has been minimized.

Copy link

commented Aug 13, 2019

The same HTTP request, with included filters as GET params, but without the list filters configuration should filter the list as well, IMHO.

How is it supposed to work without a preconfiguration? It seems fragile and a bit magic/convention to me.

@alterphp

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Most of filters usage is an equality on a relation or a property, the idea is to make them implicit, like auto filters in Excel => they are fragile indeed but very efficient.

Filtering a list requires to produce some config in both cases in EAB (if i'm up to date with last features that is not sure) : dql_filter and list filters. My expectation is to quickly display a list just by adding some simple filters to an HTTP query. It's obviously restricted to equality (and why not contains for iterable properties). Something like this : https://github.com/alterphp/EasyAdminExtensionBundle/blob/master/src/EventListener/PostQueryBuilderSubscriber.php#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.