Repository navigation
Pass kwargs through for overridden pandas methods - #121
Merged
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 820 820
=========================================
Hits 820 820
|
jeff-hernandez
left a comment
jeff-hernandez
left a comment
Contributor
There was a problem hiding this comment.
Can we add kwargs to the docstring? Other than that, I think it looks good.
jeff-hernandez
self-requested a review
April 15, 2020 19:45
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Pandas DataFrame methods that LabelTimes overrides, passes extra keyword arguments to the underlying Pandas method
Closes #117