Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs through for overridden pandas methods #121

Merged
merged 3 commits into from Apr 15, 2020
Merged

Conversation

frances-h
Copy link
Contributor

For Pandas DataFrame methods that LabelTimes overrides, passes extra keyword arguments to the underlying Pandas method

Closes #117

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          820       820           
=========================================
  Hits           820       820           
Impacted Files Coverage Δ
composeml/label_times.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@jeff-hernandez jeff-hernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add kwargs to the docstring? Other than that, I think it looks good.

@jeff-hernandez jeff-hernandez self-requested a review April 15, 2020 19:45
Copy link
Collaborator

@jeff-hernandez jeff-hernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frances-h frances-h merged commit e465400 into master Apr 15, 2020
@frances-h frances-h deleted the pandas-kwargs branch April 15, 2020 19:52
@jeff-hernandez jeff-hernandez mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when optional args passed to overridden DataFrame methods
3 participants