Skip to content

Update Tests in CircleCI #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeff-hernandez merged 13 commits into from
Apr 22, 2020
Merged

Update Tests in CircleCI #128

jeff-hernandez merged 13 commits into from
Apr 22, 2020

Conversation

@jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Apr 20, 2020

This closes #127 by removing tests that use Python 3.5 and adding Python 3.8 in CircleCI.

@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          820       845   +25     
=========================================
+ Hits           820       845   +25
Impacted Files Coverage Δ
composeml/label_times.py 100.00% <ø> (ø)
composeml/demos/__init__.py 100.00% <100.00%> (ø)
composeml/conftest.py 100.00% <0.00%> (ø)
composeml/label_maker.py 100.00% <0.00%> (ø)
composeml/label_plots.py 100.00% <0.00%> (ø)
composeml/tests/test_datasets.py 100.00% <0.00%> (ø)
composeml/tests/test_featuretools.py 100.00% <0.00%> (ø)
composeml/tests/test_label_serialization.py 100.00% <0.00%> (ø)
...mposeml/tests/test_label_transforms/test_sample.py 100.00% <0.00%> (ø)

@jeff-hernandez jeff-hernandez requested a review from rwedge April 20, 2020 23:27
rwedge
rwedge reviewed Apr 21, 2020
View reviewed changes
rwedge
rwedge reviewed Apr 21, 2020
View reviewed changes
@jeff-hernandez jeff-hernandez requested a review from rwedge April 21, 2020 21:47
rwedge
rwedge reviewed Apr 21, 2020
View reviewed changes
@jeff-hernandez jeff-hernandez requested a review from rwedge April 22, 2020 20:21
rwedge
rwedge approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit 8edf5a1 into master Apr 22, 2020
@jeff-hernandez jeff-hernandez mentioned this pull request Apr 23, 2020
Merged
@jeff-hernandez jeff-hernandez deleted the update_circleci branch May 26, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rwedge rwedge rwedge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Python 3.5 Support

3 participants

@jeff-hernandez @rwedge