Repository navigation
Label Search for Multiple Targets - #130
Merged
Merged
Conversation
This reverts commit 0127612.
rwedge
reviewed
May 6, 2020
rwedge
reviewed
May 6, 2020
rwedge
reviewed
May 6, 2020
Contributor
Author
|
@rwedge the Counter class worked out well. Thanks for the suggestion. |
rwedge
reviewed
May 15, 2020
rwedge
reviewed
May 15, 2020
rwedge
reviewed
May 18, 2020
rwedge
left a comment
Contributor
There was a problem hiding this comment.
Should we test how label_times.describe works with multiple targets / dictionary of num_examplers_per_instance?
Contributor
Author
|
I think that can be tested when we update the label description in #122. |
rwedge
reviewed
May 18, 2020
kmax12
reviewed
May 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #119 by supporting more than one labeling function during the search process. This also resolves #90 by supporting search processes based on label values.