Skip to content

Label Search for Multiple Targets - #130

Merged
jeff-hernandez merged 52 commits into
masterfrom
label_search
May 22, 2020
Merged

jeff-hernandez merged 52 commits into
masterfrom
label_search

Conversation

@jeff-hernandez

@jeff-hernandez jeff-hernandez commented Apr 21, 2020 •

Copy link
Copy Markdown
Contributor

This closes #119 by supporting more than one labeling function during the search process. This also resolves #90 by supporting search processes based on label values.

@jeff-hernandez
jeff-hernandez requested a review from rwedge April 28, 2020 14:51
Comment thread composeml/label_maker.py Resolved
Comment thread composeml/label_search.py Resolved
Comment thread composeml/label_maker.py Resolved
@jeff-hernandez
jeff-hernandez requested a review from rwedge May 8, 2020 21:33
@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

@rwedge the Counter class worked out well. Thanks for the suggestion.

Comment thread composeml/label_maker.py Resolved
Comment thread composeml/tests/test_label_maker.py Resolved

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test how label_times.describe works with multiple targets / dictionary of num_examplers_per_instance?

@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

I think that can be tested when we update the label description in #122.

Comment thread composeml/label_maker.py Resolved
@jeff-hernandez
jeff-hernandez requested a review from rwedge May 21, 2020 16:13
Comment thread composeml/data_slice.py Resolved

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez
jeff-hernandez merged commit 1ab33f2 into master May 22, 2020
@jeff-hernandez
jeff-hernandez deleted the label_search branch May 26, 2020 21:43
@jeff-hernandez jeff-hernandez mentioned this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label Search for Multiple Targets No way to balance labels per entity

3 participants