Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Search for Multiple Targets #130

Merged
merged 52 commits into from May 22, 2020
Merged

Label Search for Multiple Targets #130

merged 52 commits into from May 22, 2020

Conversation

jeff-hernandez
Copy link
Collaborator

@jeff-hernandez jeff-hernandez commented Apr 21, 2020

This closes #119 by supporting more than one labeling function during the search process. This also resolves #90 by supporting search processes based on label values.

composeml/label_maker.py Outdated Show resolved Hide resolved
composeml/label_maker.py Outdated Show resolved Hide resolved
@jeff-hernandez jeff-hernandez requested a review from rwedge May 8, 2020 21:33
@jeff-hernandez
Copy link
Collaborator Author

@rwedge the Counter class worked out well. Thanks for the suggestion.

composeml/label_maker.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test how label_times.describe works with multiple targets / dictionary of num_examplers_per_instance?

@jeff-hernandez
Copy link
Collaborator Author

I think that can be tested when we update the label description in #122.

composeml/data_slice.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit 1ab33f2 into master May 22, 2020
@jeff-hernandez jeff-hernandez deleted the label_search branch May 26, 2020 21:43
@jeff-hernandez jeff-hernandez mentioned this pull request Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label Search for Multiple Targets No way to balance labels per entity
3 participants