-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinity as Edges for Binning #133
Conversation
This reverts commit a60b706.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good. Might be good to add a test in the unit tests to cover passing "inf"
and "-inf"
strings as bin edges along with a test to confirm that the precision
parameter works as expected.
Thanks @thehomebrewnerd. The docstring examples are configured as doctests which are included as unit tests in pytest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This closes #114 by supporting infinite edges when binning labels.
Example
Create a label times object.
Bin values using infinite edges.