Refactors Label Times - #135
Merged
Merged
Conversation
This reverts commit a60b706.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 26 +4
Lines 967 960 -7
=========================================
- Hits 967 960 -7
|
rwedge
reviewed
Jun 2, 2020
rwedge
reviewed
Jun 3, 2020
rwedge
reviewed
Jun 15, 2020
rwedge
left a comment
Contributor
There was a problem hiding this comment.
I like the changes. Do we want to add a warning based on if the schema version is older / newer than expected?
Contributor
Author
|
Yes, I think that's a good idea @rwedge. We can add a warning as a result from different schema versions. Perhaps it would be easier to do this in a separate PR. |
Contributor
Sounds good, can you make an issue for it? |
Contributor
Author
|
Yes, tracking this issue at #145. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label times object was refactored by: