-
Notifications
You must be signed in to change notification settings - Fork 47
Refactors Label Times #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a60b706.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 26 +4
Lines 967 960 -7
=========================================
- Hits 967 960 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes. Do we want to add a warning based on if the schema version is older / newer than expected?
Yes, I think that's a good idea @rwedge. We can add a warning as a result from different schema versions. Perhaps it would be easier to do this in a separate PR. |
Sounds good, can you make an issue for it? |
Yes, tracking this issue at #145. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The label times object was refactored by: