Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames Cutoff Time Column #139

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Renames Cutoff Time Column #139

merged 4 commits into from
Jun 1, 2020

Conversation

jeff-hernandez
Copy link
Collaborator

This closes #137 by renaming the cutoff time column to time.

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          967       967           
=========================================
  Hits           967       967           
Impacted Files Coverage Δ
composeml/label_maker.py 100.00% <ø> (ø)
composeml/tests/test_label_maker.py 100.00% <ø> (ø)
composeml/tests/test_label_times.py 100.00% <ø> (ø)
...mposeml/tests/test_label_transforms/test_sample.py 100.00% <ø> (ø)
composeml/conftest.py 100.00% <100.00%> (ø)
composeml/label_times.py 100.00% <100.00%> (ø)
composeml/tests/test_featuretools.py 100.00% <100.00%> (ø)
composeml/tests/test_label_transforms/test_lead.py 100.00% <100.00%> (ø)

@rwedge
Copy link
Contributor

rwedge commented Jun 1, 2020

should we update the changelog?

@jeff-hernandez
Copy link
Collaborator Author

Yes, will update the changelog.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god

@jeff-hernandez jeff-hernandez merged commit 408c1ce into master Jun 1, 2020
@jeff-hernandez jeff-hernandez mentioned this pull request Jun 1, 2020
@jeff-hernandez jeff-hernandez deleted the rename_cutoff_times branch June 1, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default column name used for cutoff time column
2 participants