Column Based Windows - #151
Merged
Merged
Conversation
… into column-based_windows
jeff-hernandez
marked this pull request as ready for review
July 14, 2020 22:23
jeff-hernandez
changed the base branch from
refactors_data_slice_generator
to
master
July 14, 2020 22:27
jeff-hernandez
changed the base branch from
master
to
refactors_data_slice_generator
July 14, 2020 22:27
frances-h
previously approved these changes
Jul 15, 2020
frances-h
left a comment
frances-h
left a comment
Contributor
There was a problem hiding this comment.
👍 lgtm after correction
jeff-hernandez
changed the base branch from
refactors_data_slice_generator
to
master
July 21, 2020 13:53
Contributor
|
@jeff-hernandez did you add any info about this to the documentation? |
Contributor
Author
|
@kmax12 I don't think I did. I will add to the docstrings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A column key can be used for the window size parameter. Closes #99 by allowing non-time based windows.