Skip to content

Column Based Windows #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 252 commits into from
Jul 21, 2020
Merged

Column Based Windows #151

merged 252 commits into from
Jul 21, 2020

Conversation

jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Jul 9, 2020

A column key can be used for the window size parameter. Closes #99 by allowing non-time based windows.

lm = cp.LabelMaker(
    window_size="session_id",
    ...
)

@jeff-hernandez jeff-hernandez marked this pull request as ready for review July 14, 2020 22:23
@jeff-hernandez jeff-hernandez changed the base branch from refactors_data_slice_generator to master July 14, 2020 22:27
@jeff-hernandez jeff-hernandez changed the base branch from master to refactors_data_slice_generator July 14, 2020 22:27
@jeff-hernandez jeff-hernandez requested a review from frances-h July 15, 2020 15:21
frances-h
frances-h previously approved these changes Jul 15, 2020
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm after correction

@jeff-hernandez jeff-hernandez changed the base branch from refactors_data_slice_generator to master July 21, 2020 13:53
@jeff-hernandez jeff-hernandez dismissed frances-h’s stale review July 21, 2020 13:53

The base branch was changed.

@jeff-hernandez jeff-hernandez merged commit c2f17d1 into master Jul 21, 2020
@kmax12
Copy link
Contributor

kmax12 commented Aug 11, 2020

@jeff-hernandez did you add any info about this to the documentation?

@jeff-hernandez
Copy link
Contributor Author

@kmax12 I don't think I did. I will add to the docstrings.

@jeff-hernandez jeff-hernandez mentioned this pull request Aug 28, 2020
@jeff-hernandez jeff-hernandez deleted the column-based_windows branch September 1, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow non-time-based windows
3 participants