Skip to content

Adds Chicago Bike Demo - #157

Merged
jeff-hernandez merged 246 commits into
mainfrom
adds_chicago_bike_demo
Sep 1, 2020
Merged

jeff-hernandez merged 246 commits into
mainfrom
adds_chicago_bike_demo

Conversation

@jeff-hernandez

@jeff-hernandez jeff-hernandez commented Aug 18, 2020 •

Copy link
Copy Markdown
Contributor

Adds the Chicago Bike Demo to the docs.

@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

@thehomebrewnerd thanks for the great feedback! The PR has been updated and is ready for another review.

@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

I also updated the other notebooks based on the same feedback.

@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

I think it would be helpful to have the notebooks on google colab.

@jeff-hernandez

Copy link
Copy Markdown
Contributor Author

@thehomebrewnerd the section for making predictions has been updated and is ready for review.

@jeff-hernandez jeff-hernandez added the documentation Improvements or additions to documentation label Aug 26, 2020
@thehomebrewnerd

Copy link
Copy Markdown
Contributor

@jeff-hernandez Another thought in terms of the discussion - instead of using the term "future data", maybe we should call this "new data" instead, if we are going to use this approach. The word "future" could be a little confusing. How could we obtain future data to make predictions?

Instead, I think what we are trying to illustrate is that after we have built a model we might acquire additional data, and we can combine this "new" data with the old data to create a new feature matrix that we can then be used to make predictions.

thehomebrewnerd
thehomebrewnerd previously approved these changes Sep 1, 2020

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-hernandez Noticed a couple minor spelling/wording issues, but otherwise looking good!

thehomebrewnerd
thehomebrewnerd previously approved these changes Sep 1, 2020

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more spelling issues to fix, but otherwise looks good!

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-hernandez
jeff-hernandez merged commit 66e04a1 into main Sep 1, 2020
@jeff-hernandez
jeff-hernandez deleted the adds_chicago_bike_demo branch September 1, 2020 20:33
@jeff-hernandez jeff-hernandez mentioned this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants