-
Notifications
You must be signed in to change notification settings - Fork 47
Test Doc Builds #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Doc Builds #165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1254 1254
=========================================
Hits 1254 1254 |
The docs take ~12 minutes to build on CircleCI. Locally, it takes about a minute. Not sure if this is a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, only comment is if you want warnings to be treated as errors by the docs build, there's a flag you need to set
Hmm, after updating the doc builds to treat warnings as errors, a context deadline exceeded problem occurs on CircleCI. I don't get any errors when building the docs locally. Solved by increasing the no output timeout (f4e4a1d). |
Found this on CircleCI Support:
|
I reran a previous commit on CircleCi and also got a timeout, so the warnings as errors may not be the issue. It seems that a lot of time is being spent building the page on the fan degradation example |
On Read the Docs, the latest build with the notebooks took ~6 minutes. On CircleCI, it took ~20 minutes. |
I'm thinking about using a smaller sample of data in the notebooks to speed up the doc builds on CircleCI . |
What if we tried using a time-based timeout for the EvalML search instead of number of pipelines? |
@rwedge sounds good, will try the time-based search. |
The latest build on CircleCI with an additional notebook took ~37 minutes. |
The latest build using smaller samples of data took ~28 minutes on CircleCI. |
After increasing the resource class of the executor, the latest build took ~11 minutes. |
After limiting the search by model type, the build took a minute! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Closes #159 by adding integration tests for doc builds.