Skip to content

Pandas Doc Theme#172

Merged
jeff-hernandez merged 25 commits into
mainfrom
pandas_doc_theme
Sep 14, 2020
Merged

Pandas Doc Theme#172
jeff-hernandez merged 25 commits into
mainfrom
pandas_doc_theme

Conversation

@jeff-hernandez

Copy link
Copy Markdown
Contributor

Closes #158 by applying the pandas doc theme to the documentation.

@codecov

codecov Bot commented Sep 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #172 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1254      1254           
=========================================
  Hits          1254      1254           
Impacted Files Coverage Δ
composeml/label_times/plots.py 100.00% <100.00%> (ø)

@jeff-hernandez jeff-hernandez added the documentation Improvements or additions to documentation label Sep 4, 2020
@rwedge

rwedge commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

the "main concepts" page is still searchable but does not appear to be reachable via the "next" button or the nav bar

Comment thread docs/source/index.rst Outdated
Comment thread docs/source/user_guide.rst Outdated
@rwedge

rwedge commented Sep 11, 2020

Copy link
Copy Markdown
Contributor
  • Can we drop sphinx rtd theme as a requirement
  • Can we name our other top-level topics to match evalml'ls

Comment thread docs/source/user_guide.rst Outdated
Comment thread docs/source/install.rst Outdated
@rwedge

rwedge commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Screen Shot 2020-09-09 at 2 17 58 PM

This warning seems to be specific to the new docs theme

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-hernandez jeff-hernandez merged commit f71a174 into main Sep 14, 2020
@jeff-hernandez jeff-hernandez deleted the pandas_doc_theme branch September 14, 2020 22:12
@jeff-hernandez jeff-hernandez mentioned this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pandas Doc Theme

2 participants