Skip to content

Sorted Distribution - #188

Merged
jeff-hernandez merged 12 commits into
mainfrom
sorted_distribution
Nov 25, 2020
Merged

Sorted Distribution#188
jeff-hernandez merged 12 commits into
mainfrom
sorted_distribution

Conversation

@jeff-hernandez

Copy link
Copy Markdown
Contributor

Closes #111 by sorting distribution before converting to string.

@codecov

codecov Bot commented Oct 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #188 (83bbf60) into main (f4d69a5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1254      1254           
=========================================
  Hits          1254      1254           
Impacted Files Coverage Δ
composeml/label_times/description.py 100.00% <100.00%> (ø)
composeml/tests/test_label_times.py 100.00% <100.00%> (ø)

@CLAassistant

CLAassistant commented Nov 4, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tuethan1999 tuethan1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the word sorted should be somewhere in the test name/description

@tuethan1999 tuethan1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeff-hernandez
jeff-hernandez merged commit e9d352f into main Nov 25, 2020
@jeff-hernandez
jeff-hernandez deleted the sorted_distribution branch November 25, 2020 21:02
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label distribution in describe out of order after binning

3 participants