Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorted Distribution #188

Merged
merged 12 commits into from Nov 25, 2020
Merged

Sorted Distribution #188

merged 12 commits into from Nov 25, 2020

Conversation

jeff-hernandez
Copy link
Collaborator

Closes #111 by sorting distribution before converting to string.

@codecov
Copy link

codecov bot commented Oct 22, 2020 •
edited

Codecov Report

Merging #188 (83bbf60) into main (f4d69a5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1254      1254           
=========================================
  Hits          1254      1254
Impacted Files Coverage Δ
composeml/label_times/description.py 100.00% <100.00%> (ø)
composeml/tests/test_label_times.py 100.00% <100.00%> (ø)

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

tuethan1999
tuethan1999 reviewed Nov 25, 2020
View reviewed changes
Copy link

@tuethan1999 tuethan1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the word sorted should be somewhere in the test name/description

tuethan1999
tuethan1999 approved these changes Nov 25, 2020
View reviewed changes
Copy link

@tuethan1999 tuethan1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeff-hernandez jeff-hernandez merged commit e9d352f into main Nov 25, 2020
@jeff-hernandez jeff-hernandez deleted the sorted_distribution branch November 25, 2020 21:02
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuethan1999 tuethan1999 tuethan1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label distribution in describe out of order after binning
3 participants
@jeff-hernandez @CLAassistant @tuethan1999