Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation #195

Merged
merged 20 commits into from Dec 9, 2020
Merged

Improve Documentation #195

merged 20 commits into from Dec 9, 2020

Conversation

jeff-hernandez
Copy link
Collaborator

The documentation was updated based on feedback.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #195 (2d94bef) into main (3c7b4b7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1259      1259           
=========================================
  Hits          1259      1259           

@jeff-hernandez jeff-hernandez added the documentation Improvements or additions to documentation label Dec 3, 2020
tyler3991
tyler3991 previously approved these changes Dec 4, 2020
Copy link

@tyler3991 tyler3991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Saw a few "we" in there still, but they were in Parker's suggestions. I'll follow up with him but I think this is great!

Base automatically changed from add_resources_page to main December 4, 2020 19:57
@jeff-hernandez jeff-hernandez dismissed tyler3991’s stale review December 4, 2020 19:57

The base branch was changed.

@jeff-hernandez jeff-hernandez merged commit 3a83a05 into main Dec 9, 2020
1 check passed
@jeff-hernandez jeff-hernandez deleted the update_docs branch December 9, 2020 15:48
@jeff-hernandez jeff-hernandez mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants